From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxGKy-0003zJ-NK for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:51:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxGKw-0008H5-VO for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:51:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxGKw-0008G2-MP for qemu-devel@nongnu.org; Thu, 11 Jul 2013 08:51:06 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6BCp4jV009128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Jul 2013 08:51:05 -0400 Message-ID: <51DEAA37.5070103@redhat.com> Date: Thu, 11 Jul 2013 06:51:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373363617-4723-1-git-send-email-kwolf@redhat.com> <1373363617-4723-6-git-send-email-kwolf@redhat.com> <51DEA7DD.1030301@redhat.com> In-Reply-To: <51DEA7DD.1030301@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LVEBNGUELWTMNEGBHKHV" Subject: Re: [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LVEBNGUELWTMNEGBHKHV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/11/2013 06:41 AM, Eric Blake wrote: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: >> These can be used when an embedded struct is parsed and members not >> belonging to the struct may be present in the input (parsing flat >> namespect QMP union with discriminator) >=20 > namespect? Not sure if you meant 'namespaced'? >=20 > Again, a comment demonstrating in sample QMP on what this is attempting= > would be helpful in the commit message. Without looking at later > patches yet, Now that I've read the commit message of patch 6/11, may I suggest something along the lines of this wording: Add a new visitor that allows parsing of an implicit struct, which is created by inlining the namespace of the nested union 'data' struct into the top-level struct of the union itself. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2LVEBNGUELWTMNEGBHKHV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3qo3AAoJEKeha0olJ0NqORgIAIj/Qvb4bQEBdIwe3W3lVJag CF2DnU6M2tlIyDSYcVnvIQ/3pUswxsRdLro0eennS3JiA//BR4zUduaNUlhKOWuI Y9wBJrUt0ityssjScqEL5meCr/1SCMAG65Oi7qibUfZ35BcULy6R2ojMofk4CxFi pRjae74Bwm63ry4qJ+YaJr7eeZZWQdl7lnxRZC+S6f5iNKwghD2CDsBNLVGmjIxI B6qbalSJ1dTtQ+QL2TK6Pa1cW7DtYsD0Fq1CQg/9qa5sB+8zgwMs+XJuJ3Vz6DVo U55y9Vq3ysYhsODYKLGsbdYME1+tCvPJyqVIPaO+qKc7fkKWwRHk/m2hVTKh/Sw= =5AEf -----END PGP SIGNATURE----- ------enig2LVEBNGUELWTMNEGBHKHV--