From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxKA1-0005tO-W8 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 12:56:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxK9z-0007gm-0v for qemu-devel@nongnu.org; Thu, 11 Jul 2013 12:56:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxK9y-0007gS-P0 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 12:56:02 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6BGu2sO027161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Jul 2013 12:56:02 -0400 Message-ID: <51DEE433.30404@redhat.com> Date: Thu, 11 Jul 2013 18:58:27 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1373464153-18979-1-git-send-email-mst@redhat.com> <1373464153-18979-4-git-send-email-mst@redhat.com> <51DEE389.4080201@redhat.com> In-Reply-To: <51DEE389.4080201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 repost 3/9] acpi: add rules to compile ASL source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 07/11/13 18:55, Laszlo Ersek wrote: > On 07/10/13 15:51, Michael S. Tsirkin wrote: >> Detect presence of IASL compiler and use it >> to process ASL source. If not there, use pre-compiled >> files in-tree. Add script to update the in-tree files. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> configure | 9 ++++++++- >> hw/i386/Makefile.objs | 22 ++++++++++++++++++++++ >> scripts/update-acpi.sh | 4 ++++ >> 3 files changed, 34 insertions(+), 1 deletion(-) >> create mode 100644 scripts/update-acpi.sh > > I think: > - this patch (3/9) should be swapped with the next one (4/9), so that > the pre-generated files are available earlier than the build code > potentially relying on them, > - the "iasl-option" trick should be moved to ./configure perhaps. Reviewed-by: Laszlo Ersek anyway