From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxLz9-0002mI-TE for qemu-devel@nongnu.org; Thu, 11 Jul 2013 14:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxLz8-0007yE-F8 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 14:52:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxLz8-0007y8-63 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 14:52:58 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6BIqvQm008548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Jul 2013 14:52:57 -0400 Message-ID: <51DEFF08.6060308@redhat.com> Date: Thu, 11 Jul 2013 12:52:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373552895-17349-1-git-send-email-akong@redhat.com> In-Reply-To: <1373552895-17349-1-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2STBTGALPWKKOAVJFCNLS" Subject: Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: armbru@redhat.com, qemu-devel@nongnu.org, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2STBTGALPWKKOAVJFCNLS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/11/2013 08:28 AM, Amos Kong wrote: > Markus added some comments on old patchset, this patch contains > some additional fixes, it's based on MST's PCI tree. >=20 > * Fix typos (missed 1.6, NIC) > * Don't initialize list point at its declaration > * Always notify QMP client if mactable is changed > * Returns NULL list if no net client supports rx-filter querying. >=20 > BTW, we can also use e1000 with macvtap device, so we can implement > a query_rx_filter function for e1000 in future. >=20 > Signed-off-by: Amos Kong > --- > hw/net/virtio-net.c | 24 ++++++++++++++---------- > net/net.c | 19 ++++++++++--------- > qapi-schema.json | 11 ++++++----- > qmp-commands.hx | 10 +++++----- > 4 files changed, 35 insertions(+), 29 deletions(-) Reviewed-by: Eric Blake > @@ -3724,13 +3724,14 @@ > # > # @all: receive all assigned packets > # > +# Since: 1.6 > ## > { 'enum': 'RxState', 'data': [ 'normal', 'none', 'all' ] } I don't see RxState in the latest qemu.git (c170a23c); is it worth trying to squash this in place to the pull request of the earlier series, instead of as a followup patch? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2STBTGALPWKKOAVJFCNLS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR3v8IAAoJEKeha0olJ0NquwoH/A8ST1l7+PuO/OLqGDA2u7TF 78ULRVg2WvsX+H+OJDS1qtXc4ehVt0uvRy3SOzXXcaxqLDaPBZAbCKsd1Fp23dky 9Qqe/MILpP4RlmieAa4kGxxwMiPK/+5o9aowSmx3oLu/IlLi3FaRfbxUTd7+nwVp Qit04VVU9wp3wGKD2Y0gMPp9BmX6s+Ct7fZBv03l2j4D2w1uHsxvVvE7/assEi4Q eRWPinRMpdarsVTEOUcOYMAzZ5jFSu8vh6ztVY17v1UNhNO2mxHiO7aB8NIcPBYT ElNzP7nvePzOFEqgcjvUO3G3+Wwno77gZrwUoQgEbThhRLNGudTQkyVkrDfRKkE= =6C9h -----END PGP SIGNATURE----- ------enig2STBTGALPWKKOAVJFCNLS--