qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()
Date: Fri, 12 Jul 2013 08:58:03 +0200	[thread overview]
Message-ID: <51DFA8FB.4000703@redhat.com> (raw)
In-Reply-To: <1373478767-20965-7-git-send-email-lcapitulino@redhat.com>

Il 10/07/2013 19:52, Luiz Capitulino ha scritto:
> From: Seiji Aguchi <seiji.aguchi@hds.com>
> 
> [Issue]
> When we offer a customer support service and a problem happens
> in a customer's system, we try to understand the problem by
> comparing what the customer reports with message logs of the
> customer's system.
> 
> In this case, we often need to know when the problem happens.
> 
> But, currently, there is no timestamp in qemu's error messages.
> Therefore, we may not be able to understand the problem based on
> error messages.
> 
> [Solution]
> Add a timestamp to qemu's error message logged by
> error_report() with g_time_val_to_iso8601().
> 
> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

What about removing the option, and instead:

- logging no timestamp until the virtual machine has started

- always logging timestamps after the virtual machine has started

?

Paolo

  reply	other threads:[~2013-07-12  6:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 17:52 [Qemu-devel] [PULL 0/6] QMP queue Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 1/6] qemu-char: Fix ringbuf option size Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 2/6] qapi.py: Avoid code duplication Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 3/6] qapi.py: Allow top-level type reference for command definitions Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 4/6] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 5/6] qapi-schema: Use existing type for drive-backup arguments Luiz Capitulino
2013-07-10 17:52 ` [Qemu-devel] [PULL 6/6] add timestamp to error_report() Luiz Capitulino
2013-07-12  6:58   ` Paolo Bonzini [this message]
2013-07-12 12:46     ` Luiz Capitulino
2013-07-12 14:23       ` Seiji Aguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DFA8FB.4000703@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).