From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41397)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UxXIz-0004C5-TC
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:58:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UxXIy-0005IC-3y
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:58:13 -0400
Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:64618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UxXIx-0005Hp-UB
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 02:58:12 -0400
Received: by mail-ee0-f46.google.com with SMTP id d41so5961256eek.5
	for <qemu-devel@nongnu.org>; Thu, 11 Jul 2013 23:58:10 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51DFA8FB.4000703@redhat.com>
Date: Fri, 12 Jul 2013 08:58:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com>
	<1373478767-20965-7-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1373478767-20965-7-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Il 10/07/2013 19:52, Luiz Capitulino ha scritto:
> From: Seiji Aguchi <seiji.aguchi@hds.com>
> 
> [Issue]
> When we offer a customer support service and a problem happens
> in a customer's system, we try to understand the problem by
> comparing what the customer reports with message logs of the
> customer's system.
> 
> In this case, we often need to know when the problem happens.
> 
> But, currently, there is no timestamp in qemu's error messages.
> Therefore, we may not be able to understand the problem based on
> error messages.
> 
> [Solution]
> Add a timestamp to qemu's error message logged by
> error_report() with g_time_val_to_iso8601().
> 
> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

What about removing the option, and instead:

- logging no timestamp until the virtual machine has started

- always logging timestamps after the virtual machine has started

?

Paolo