From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Uxa6H-0006I2-Aw
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 05:57:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Uxa6C-00070Z-2k
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 05:57:17 -0400
Message-ID: <51DFD2F5.3020004@adacore.com>
Date: Fri, 12 Jul 2013 11:57:09 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1373476202-11277-1-git-send-email-chouteau@adacore.com>
	<1373476202-11277-2-git-send-email-chouteau@adacore.com>
	<CAFEAcA9NAHRj750zayLHcPsEamU=nP7Kf_68Nqu6Ts6TrHL=Fw@mail.gmail.com>
In-Reply-To: <CAFEAcA9NAHRj750zayLHcPsEamU=nP7Kf_68Nqu6Ts6TrHL=Fw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Add be16_to_cpupu function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de

On 07/10/2013 07:25 PM, Peter Maydell wrote:
> On 10 July 2013 18:10, Fabien Chouteau <chouteau@adacore.com> wrote:
>> --- a/include/qemu/bswap.h
>> +++ b/include/qemu/bswap.h
>> @@ -432,6 +432,11 @@ static inline uint32_t le32_to_cpupu(const uint32_t *p)
>>      return ldl_le_p(p);
>>  }
>>
>> +static inline uint16_t be16_to_cpupu(const uint16_t *p)
>> +{
>> +    return lduw_be_p(p);
>> +}
>> +
> 
> So these functions are preceded by the comment:
> /* Legacy unaligned versions.  Note that we never had a complete set.  */
> 
> which suggests that we shouldn't be adding new ones.
> I think the correct answer is to use lduw_be_p() directly.
> (If so it's tempting to get rid of the legacy functions
> completely since the change would be pretty mechanical.)
> 

OK noted.

Thanks,

-- 
Fabien Chouteau