qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
	Stefano.Stabellini@eu.citrix.com, wei.lui2@citrix.com,
	Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu
Date: Fri, 12 Jul 2013 17:13:42 +0100	[thread overview]
Message-ID: <51E02B36.709@eu.citrix.com> (raw)
In-Reply-To: <1373637490-6262-1-git-send-email-fabio.fantoni@m2r.biz>

On 12/07/13 14:58, Fabio Fantoni wrote:
> Usage: usbversion=1|2|3 (default=2)
> Specifies the type of an emulated USB bus in the guest. 1 for usb1,
> 2 for usb2 and 3 for usb3, it is available only with upstream qemu.
> Default is 2.
>
> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>

Thank you for your enthusiastic respin and resubmission; however, it's 
generally a good idea to wait for a day or two to make sure that points 
are sufficiently discussed  before doing so.  For instance, I probably 
would have quibbled with Ian about the for() loop under usbversion=2; 
and we didn't finish talking about the "id=usb" component.

  -George

  reply	other threads:[~2013-07-12 16:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 13:58 [Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu Fabio Fantoni
2013-07-12 16:13 ` George Dunlap [this message]
2013-07-12 22:12 ` [Qemu-devel] [Xen-devel] " Dario Faggioli
2013-07-15  9:11 ` [Qemu-devel] " Fabio Fantoni
2013-09-13 11:59   ` Ian Campbell
2013-09-13 13:42     ` Fabio Fantoni
2013-09-13 13:54       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E02B36.709@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=fabio.fantoni@m2r.biz \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wei.lui2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).