From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxfzF-0000P1-1p for qemu-devel@nongnu.org; Fri, 12 Jul 2013 12:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxfzA-0000Y2-BP for qemu-devel@nongnu.org; Fri, 12 Jul 2013 12:14:25 -0400 Received: from smtp.citrix.com ([66.165.176.89]:6002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxfz9-0000Xk-TA for qemu-devel@nongnu.org; Fri, 12 Jul 2013 12:14:20 -0400 Message-ID: <51E02B36.709@eu.citrix.com> Date: Fri, 12 Jul 2013 17:13:42 +0100 From: George Dunlap MIME-Version: 1.0 References: <1373637490-6262-1-git-send-email-fabio.fantoni@m2r.biz> In-Reply-To: <1373637490-6262-1-git-send-email-fabio.fantoni@m2r.biz> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabio Fantoni Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, wei.lui2@citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, pbonzini@redhat.com On 12/07/13 14:58, Fabio Fantoni wrote: > Usage: usbversion=1|2|3 (default=2) > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > Default is 2. > > Signed-off-by: Fabio Fantoni Thank you for your enthusiastic respin and resubmission; however, it's generally a good idea to wait for a day or two to make sure that points are sufficiently discussed before doing so. For instance, I probably would have quibbled with Ian about the for() loop under usbversion=2; and we didn't finish talking about the "id=usb" component. -George