From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxgj3-0003oT-Mn for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uxgig-0000C8-GW for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:01:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxgid-0000BL-AM for qemu-devel@nongnu.org; Fri, 12 Jul 2013 13:01:22 -0400 Message-ID: <51E0365C.2070007@redhat.com> Date: Fri, 12 Jul 2013 11:01:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1371477707-7039-1-git-send-email-kraxel@redhat.com> <1371477707-7039-3-git-send-email-kraxel@redhat.com> <87a9mo4x38.fsf@codemonkey.ws> <20130617105018.26c2eadc@redhat.com> <51C02766.5020301@redhat.com> In-Reply-To: <51C02766.5020301@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VDUDKOPLDQRBQWRAOIEV" Subject: Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Markus Armbruster , Anthony Liguori , alevy@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VDUDKOPLDQRBQWRAOIEV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/18/2013 03:24 AM, Gerd Hoffmann wrote: >>>> >> > We have a job API in the block layer. Would it make sense to h= ave a >>>> >> > QMP-level job interface? >> > I'd agree with this. > Something like the attached patch? Which is just the bare minimum I'll= > need for screendump. Basically a one-off bottom half with some monitor= > infrastructure (job id, error handling). So it isn't for big jobs, but= > for small jobs which have to wait for something before they execute > (spice-server, guest action, whatever). >=20 > If you wanna some more context: screendump on top of that is here: > https://www.kraxel.org/cgit/qemu/log/?h=3Drebase/pixman >=20 > + > +void monitor_job_cancel(monitor_job *job) > +{ > + monitor_job_event(job, "canceled", NULL); > + if (job->bh) { > + qemu_bh_delete(job->bh); > + } > + g_free(job); > +} What calls this command? > diff --git a/qapi-schema.json b/qapi-schema.json > index aced724..a449a43 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2515,6 +2515,16 @@ > 'str': 'str' } } > =20 > ## > +# @MonitorJob > +# > +# Monitor job id. > +# No mention of @job-id? > +# Since 1.6 > +## > +{ 'type': 'MonitorJob', > + 'data': { 'job-id': 'int' } } For a type, this looks okay; but where are the commands that use this type? I take it new commands (like screendump) would return a MonitorJob, and that we need a query-monitor-jobs as well as a monitor-job-cancel. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VDUDKOPLDQRBQWRAOIEV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR4DZcAAoJEKeha0olJ0NqvLEH/AhnQLZz/dk1eB8urIsu38O7 HpG3fagwDtZI6PJhuXPFtENbWE/QE3cCwFsXt5aaamcxalSqYhyVxC0s8L+/VWWO qcYcUYmZxhXId466rerGYfc/XapQ757R5TMRzELjq6ro2z/cFTl90O7jn5boP0O6 8rhqED1FzibBMSat4OktPX+QzhgtQUnxGJ+0zyH8iyO5/G9SuOSoNF43EuSiJ37p s3lzCA4xdSMtiJq7NmGXTzuN+VNuC6af4Nxe9xlXmxMnoYavhSi7froMVkihalZ/ Y8BMf6jgsZlFhXZGK+wjLV3gUzPKS1DeEoMrhP2lPDn8lsDYG6T0jkS4hnRaAZo= =jjbs -----END PGP SIGNATURE----- ------enig2VDUDKOPLDQRBQWRAOIEV--