From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UygNh-0005Uq-Qo for qemu-devel@nongnu.org; Mon, 15 Jul 2013 06:51:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UygNg-0002Sm-Rd for qemu-devel@nongnu.org; Mon, 15 Jul 2013 06:51:49 -0400 Received: from mail-ee0-x231.google.com ([2a00:1450:4013:c00::231]:65136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UygNg-0002SW-Lf for qemu-devel@nongnu.org; Mon, 15 Jul 2013 06:51:48 -0400 Received: by mail-ee0-f49.google.com with SMTP id b57so7483263eek.22 for ; Mon, 15 Jul 2013 03:51:47 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51E3D43B.2090504@redhat.com> Date: Mon, 15 Jul 2013 12:51:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1373074528-16181-1-git-send-email-imain@redhat.com> <20130706013818.GE7462@gate.mains.priv> In-Reply-To: <20130706013818.GE7462@gate.mains.priv> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 0/2] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main , qemu-devel Il 06/07/2013 03:38, Ian Main ha scritto: >> > This patch adds sync modes on top of the work that Stefan Hajnoczi has done. >> > >> > These patches apply on kevin/block with >> > '[PATCH] block: add drive_backup HMP command' also applied. >> > >> > Hopefully all is in order as this is my first QEMU patch. Many thanks to >> > Stephan and Fam Zheng for their help. >> > >> > V2: >> > >> > - No longer poll, instead use qemu_coroutine_yield(). >> > - Use bdrv_co_is_allocated(). >> > - Much better SYNC_MODE_NONE test. > FYI I'll be off camping for all next week so I won't get back to you > until the following week. Thanks in advance for any reviews! I'm still not sure how "none" works (see my discussion with Fam in the v1 thread). Paolo