From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UymTM-0005G2-PI
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 13:22:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UymTL-0000Z5-Rx
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 13:22:04 -0400
Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:44959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UymNZ-0007Ar-NA
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 13:16:05 -0400
Received: by mail-qc0-f175.google.com with SMTP id k14so6349284qcv.6
	for <qemu-devel@nongnu.org>; Mon, 15 Jul 2013 10:16:05 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51E42E4B.1090604@redhat.com>
Date: Mon, 15 Jul 2013 19:15:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1373903207-27085-1-git-send-email-cornelia.huck@de.ibm.com>
	<874nbvsr3d.fsf@codemonkey.ws>
In-Reply-To: <874nbvsr3d.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-1?Q?Aur=E9lien_Jarno?= <aurelien@aurel32.net>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Il 15/07/2013 18:52, Anthony Liguori ha scritto:
> Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> 
>> The following changes since commit c3cb8e77804313e1be99b5f28a34a346736707a5:
>>
>>   ioport: remove LITTLE_ENDIAN mark for portio (2013-07-12 14:37:47 -0500)
>>
>> are available in the git repository at:
>>
>>   git://github.com/cohuck/qemu virtio-ccw-upstr
>>
>> for you to fetch changes up to bf72d89f0a8fb27a6bfde1a689690fd577227762:
>>
>>   virtio-ccw: Enable x-data-plane for virtio-ccw-blk (2013-07-15
>>   17:39:04 +0200)
> 
> This is v1?  This was just posted on Thursday?  That's a bit too quick
> for a pull request.
> 
> I've seen no review from Stefan or Paolo and I would think that given
> the work that's been done already, it would be counterproductive to
> enable x-data-plane for another backend.
> 
> Paolo/Stefan, what do you guys think?

Considering what the patch looks like, I don't think it's a huge
problem...  In fact, perhaps x-data-plane could be even added to
DEFINE_VIRTIO_BLK_PROPERTIES.  This would make it clear that support for
non-ioeventfd hosts (including TCG) is one of the things to do to make
data plane the default.

Paolo