From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Uypqr-0006ic-Pb
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 16:58:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Uypqq-0003Ti-Q8
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 16:58:33 -0400
Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:39158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Uypqq-0003Te-Ia
	for qemu-devel@nongnu.org; Mon, 15 Jul 2013 16:58:32 -0400
Received: by mail-ea0-f170.google.com with SMTP id h10so8210913eaj.1
	for <qemu-devel@nongnu.org>; Mon, 15 Jul 2013 13:58:31 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51E4626E.4090703@redhat.com>
Date: Mon, 15 Jul 2013 22:58:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1373911262-11972-1-git-send-email-imain@redhat.com>
In-Reply-To: <1373911262-11972-1-git-send-email-imain@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 0/2] Implement sync modes for
	drive-backup.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Main <imain@redhat.com>
Cc: qemu-devel@nongnu.org

Il 15/07/2013 20:01, Ian Main ha scritto:
> This patch adds sync modes on top of the work that Stefan Hajnoczi has done.
> 
> These patches apply on kevin/block with 
> '[PATCH] block: add drive_backup HMP command' also applied.
> 
> Hopefully all is in order as this is my first QEMU patch.  Many thanks to 
> Stephan and Fam Zheng for their help.
> 
> V2:
> 
> - No longer poll, instead use qemu_coroutine_yield().
> - Use bdrv_co_is_allocated().
> - Much better SYNC_MODE_NONE test.
> 
> V3:
> 
> - A few style fixes.
> - Better commit message explaining how TOP and NONE operate.
> - Verified using checkpatch.pl.
> 
> Ian Main (2):
>   Implement sync modes for drive-backup.
>   Add tests for sync modes 'TOP' and 'NONE'
> 
>  block/backup.c                | 91 +++++++++++++++++++++++++++++--------------
>  blockdev.c                    | 25 ++++++++----
>  include/block/block_int.h     |  4 +-
>  qapi-schema.json              |  4 ++
>  qmp-commands.hx               |  1 +
>  tests/qemu-iotests/055        | 67 +++++++++++++++++++++++++++++--
>  tests/qemu-iotests/055.out    |  4 +-
>  tests/qemu-iotests/group      |  2 +-
>  tests/qemu-iotests/iotests.py |  5 +++
>  9 files changed, 157 insertions(+), 46 deletions(-)
> 

This still doesn't have a working NONE when used with the NBD server,
which is one of the two cases which we actually care about.

Paolo