From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46531)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aavati@redhat.com>) id 1UyyNU-00082a-2p
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 02:04:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aavati@redhat.com>) id 1UyyNT-00059M-3h
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 02:04:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aavati@redhat.com>) id 1UyyNS-00058z-T2
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 02:04:47 -0400
Message-ID: <51E4E27C.2080009@redhat.com>
Date: Mon, 15 Jul 2013 23:04:44 -0700
From: Anand Avati <aavati@redhat.com>
MIME-Version: 1.0
References: <20130712065614.GI32532@in.ibm.com>
	<20130712065854.GJ32532@in.ibm.com>
	<20130716060238.GA29714@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130716060238.GA29714@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to
 configure GlusterFS block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Bharata B Rao <bharata@linux.vnet.ibm.com>

On 7/15/13 11:02 PM, Stefan Hajnoczi wrote:
> On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote:
>> gluster: Use pkg-config to configure GlusterFS block driver
>
> The commit message is duplicated in the commit description.
>
>> Use pkg-config to determine the version and library dependency
>> for GlusterFS block driver.
>>
>> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
>> ---
>>   configure |   20 +++++++-------------
>>   1 file changed, 7 insertions(+), 13 deletions(-)
>>
>> diff --git a/configure b/configure
>> index cb0f870..76adcb1 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2566,23 +2566,17 @@ fi
>>   ##########################################
>>   # glusterfs probe
>>   if test "$glusterfs" != "no" ; then
>> -  cat > $TMPC <<EOF
>> -#include <glusterfs/api/glfs.h>
>> -int main(void) {
>> -    (void) glfs_new("volume");
>> -    return 0;
>> -}
>> -EOF
>> -  glusterfs_libs="-lgfapi -lgfrpc -lgfxdr"
>> -  if compile_prog "" "$glusterfs_libs" ; then
>> -    glusterfs=yes
>> -    libs_tools="$glusterfs_libs $libs_tools"
>> -    libs_softmmu="$glusterfs_libs $libs_softmmu"
>> +  if $pkg_config --atleast-version=3 glusterfs-api >/dev/null 2>&1; then
>
> gfapi was added in Gluster 3.4.  Is --atleast-version=3 sufficient?
>

--atleast-version=3 is the api version (not release version). 3 is 
sufficient for basic qemu integration. 5 and above has fallocate/discard.

Avati