From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Liu Ping Fan" <pingfank@linux.vnet.ibm.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel <qemu-devel@nongnu.org>,
"Alexander Graf" <agraf@suse.de>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Andreas Färber" <afaerber@suse.de>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer
Date: Tue, 16 Jul 2013 09:33:04 +0200 [thread overview]
Message-ID: <51E4F730.5070907@redhat.com> (raw)
In-Reply-To: <51E4F3C1.5030201@web.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 16/07/2013 09:18, Jan Kiszka ha scritto:
> Sorry for sending out invitations and then being late to this party
> - vacation. What is the status now? Do we have a short-term plan to
> avoid the regression or is this better solved by cleaning up the
> whole endianess thing? Is anyone actively on it, or should I take a
> drink, sit down and join the discussion?
Basically, we need testing. The current state of the tree is before
Herve's patch, which means PREP is (should be) broken.
Alexey posted a patch that reintroduces the DEVICE_LITTLE_ENDIAN and
removes the cpu_{in,out}{b,w,l} indirection.
http://permalink.gmane.org/gmane.comp.emulators.qemu/222345
We need to test platforms that used a cpu_{in,out}{b,w,l} indirection
(MIPS, PPC, SPARC) with and without Alexey's patch.
The other occurrences of indirections are:
- - hw/isa/i82378.c: This is PREP. Again, removing the indirection
should be tested by Herve or Andreas on top of Alexey's patch.
- - hw/isa/isa_mmio: bamboo, g3beige and mac99 could be tested by Alex.
I don't know about MIPS. If anything is broken, the solution is to
replace isa_mmio_{setup,init} with an alias to get_system_io(). This
stops using isa_mmio altogether, so it can be done only on those
platforms where it's needed.
- - hw/pci-host/apb.c: this is SPARC. Perhaps Mark Cave-Ayland can test
it and see if it is broken---again with and without Alexey's patch.
There is a small difference. This file uses DEVICE_NATIVE_ENDIAN and
does the byte swap itself in pci_apb_io{read,write}{b,w,l}.
There is also Alpha. It doesn't matter because it's little endian,
but anyway rth is removing the indirection.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJR5PcwAAoJEBvWZb6bTYbyAOMP/1y19WnUTxcA3+kIhQE1HU2R
ildgJ2VV3kRaY4n1HeBuXOXEQzNxwppC0c0Fq/fQpYWhUxB7Y7UTtDVq9S997EUm
SoU02UlD2+xnmgOSSTTrYNY20WBRt5/s3xkMjiQSPKItBGw1og7+72m/ydzjSPAh
DSBG/mPs12zI3WcTzaydirGVX874pV2N76TSyP+T4DMkipGlgGs1JSOP+Ib/fAWw
Hk/mIu+in7qQjv7DZ/0fJuk8cvbgafCGsKppQ5yYu2YKqkmsLhR6xPNeduWK2GMv
eRLOoobSOlQxUL4konlvI74Gw/+bFtpjWcjybDfAKcVBkm8H/zpg8SIgbmlbJzoR
Gx2bQJvj1PN9pJ/TZRo+1bcw4W7JXKN94s8CTWCL8eGDELB7BgNZFXrxnyfPrY5f
8ega3uZVtZ6SmtPMO7g5arQDfqdvplH/oQozK0muxXgfBzWwvF0Y/qDNRHY18yXC
ZdPdEI2FmslOp8ZzhFW+VApfJXDADlC9xOV9rIJ0jqOewBdJlKrEkqJ8oedYGsPM
am3fmRL3N/KJ1y59hkNEpGhF6yHS7eHJBVNYp0YakthKOKhZTcBfBryFs1Yo5zwt
zvozbSEM0wXnL2ajSwWmU5drH59GdtmYdsIyOm52Etobiu002SZ1VeuCEQOORTTL
qtqyWS4kFP/PTTm8KwV4
=RIcU
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-07-16 7:34 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 6:06 [Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 01/14] adlib: replace register_ioport* Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 02/14] applesmc: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 03/14] wdt_ib700: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 04/14] i82374: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 05/14] prep: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 06/14] vt82c686: " Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 07/14] Privatize register_ioport_read/write Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 08/14] isa: implement isa_is_ioport_assigned via memory_region_find Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 09/14] vmware-vga: Accept unaligned I/O accesses Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 10/14] xen: Mark fixed platform I/O as unaligned Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer Jan Kiszka
2013-06-23 20:50 ` Hervé Poussineau
2013-06-24 6:07 ` Jan Kiszka
2013-07-11 12:29 ` Alexander Graf
2013-07-11 12:34 ` Alexander Graf
2013-07-11 12:46 ` Andreas Färber
2013-07-11 12:48 ` Alexander Graf
2013-07-11 13:28 ` Alexander Graf
2013-07-11 13:35 ` Alexander Graf
2013-07-11 22:30 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-07-11 22:32 ` Benjamin Herrenschmidt
2013-07-12 3:18 ` Alexander Graf
2013-07-12 11:35 ` Benjamin Herrenschmidt
2013-07-12 17:04 ` Hervé Poussineau
2013-07-12 19:06 ` Anthony Liguori
2013-07-12 22:59 ` Benjamin Herrenschmidt
2013-07-12 22:39 ` Benjamin Herrenschmidt
2013-07-12 17:49 ` Anthony Liguori
2013-07-12 18:26 ` Peter Maydell
2013-07-12 22:50 ` Benjamin Herrenschmidt
2013-07-12 23:10 ` Peter Maydell
2013-07-12 23:49 ` Benjamin Herrenschmidt
2013-07-15 14:01 ` Anthony Liguori
2013-07-15 14:10 ` Peter Maydell
2013-07-15 14:16 ` Benjamin Herrenschmidt
2013-07-12 22:44 ` Benjamin Herrenschmidt
2013-07-13 14:38 ` [Qemu-devel] " Paolo Bonzini
2013-07-13 15:22 ` Anthony Liguori
2013-07-13 18:11 ` Hervé Poussineau
2013-07-14 6:15 ` Paolo Bonzini
2013-07-14 13:05 ` Anthony Liguori
2013-07-14 14:58 ` Peter Maydell
2013-07-14 15:18 ` Anthony Liguori
2013-07-14 16:50 ` Peter Maydell
2013-07-16 7:18 ` Jan Kiszka
2013-07-16 7:33 ` Paolo Bonzini [this message]
2013-07-16 16:59 ` Hervé Poussineau
2013-07-16 17:12 ` Paolo Bonzini
2013-07-12 12:56 ` Anthony Liguori
2013-07-12 14:30 ` Alexander Graf
2013-07-19 11:09 ` [Qemu-devel] BUG: " Alexey Kardashevskiy
2013-07-19 12:49 ` Paolo Bonzini
2013-07-19 15:48 ` Alexey Kardashevskiy
2013-07-20 0:55 ` Alexey Kardashevskiy
2013-07-20 1:11 ` Alexey Kardashevskiy
2013-07-20 10:11 ` Paolo Bonzini
2013-07-20 20:53 ` Edgar E. Iglesias
2013-07-21 15:13 ` Hervé Poussineau
2013-07-22 10:25 ` Paolo Bonzini
2013-06-24 8:45 ` [Qemu-devel] [PATCH v4 " Jan Kiszka
2013-07-12 19:36 ` [Qemu-devel] [PATCH v3 " Anthony Liguori
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 12/14] ioport: Remove unused old dispatching services Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 13/14] vmport: Disentangle read handler type from portio Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 14/14] ioport: Move portio types to ioport.h Jan Kiszka
2013-06-23 20:45 ` [Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E4F730.5070907@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=jan.kiszka@web.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).