From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz1ep-0008Hu-FJ for qemu-devel@nongnu.org; Tue, 16 Jul 2013 05:34:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz1em-0001IC-51 for qemu-devel@nongnu.org; Tue, 16 Jul 2013 05:34:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz1el-0001Hn-TV for qemu-devel@nongnu.org; Tue, 16 Jul 2013 05:34:52 -0400 Message-ID: <51E513A1.7080306@redhat.com> Date: Tue, 16 Jul 2013 11:34:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1373903207-27085-1-git-send-email-cornelia.huck@de.ibm.com> <874nbvsr3d.fsf@codemonkey.ws> <51E42E4B.1090604@redhat.com> <20130716071041.GA30636@stefanha-thinkpad.redhat.com> <20130716105432.0415d563@gondolin> In-Reply-To: <20130716105432.0415d563@gondolin> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel , Blue Swirl , Stefan Hajnoczi , =?ISO-8859-1?Q?Aur=E9lien_Jarno?= Il 16/07/2013 10:54, Cornelia Huck ha scritto: >> > Acked-by: Stefan Hajnoczi >> > > Thank you. > > Any further guidelines on when to ask for acks from you guys? The mode > I've been operating in is mostly "if virtio-pci provides this feature, > it shouldn't be half bad and we want it in virtio-ccw as well in order > to keep things consistent and get more test coverage". I agree with these guidelines, in fact neither I nor Stefan saw a problem with your patch. :) Paolo