From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz4fU-0005TM-8j for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:47:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz4fO-0003MS-DP for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:47:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz4fO-0003MM-4t for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:47:42 -0400 Message-ID: <51E540E5.1040004@redhat.com> Date: Tue, 16 Jul 2013 14:47:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <51E5405C.6080108@siemens.com> In-Reply-To: <51E5405C.6080108@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel Il 16/07/2013 14:45, Jan Kiszka ha scritto: > This restore the behavior prior to b018ddf633 which accidentally changed > the return code to 0. Specifically guests probing for register existence > were affected by this. > > Signed-off-by: Jan Kiszka > --- > memory.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/memory.c b/memory.c > index 757e9a5..d19b61b 100644 > --- a/memory.c > +++ b/memory.c > @@ -859,7 +859,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr addr, > cpu_unassigned_access(ENV_GET_CPU(cpu_single_env), > addr, false, false, 0, size); > } > - return 0; > + return -1ULL; > } > > static void unassigned_mem_write(void *opaque, hwaddr addr, > Applied, thanks. Paolo