From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uz65p-0002Vh-DH
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 10:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uz65n-0005yT-TK
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 10:19:05 -0400
Received: from cantor2.suse.de ([195.135.220.15]:36778 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Uz65n-0005yH-NM
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 10:19:03 -0400
Message-ID: <51E55656.60201@suse.de>
Date: Tue, 16 Jul 2013 16:19:02 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1373940029-7455-1-git-send-email-proljc@gmail.com>
	<1373940029-7455-4-git-send-email-proljc@gmail.com>
In-Reply-To: <1373940029-7455-4-git-send-email-proljc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/4] target-openrisc: Free typename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org

Am 16.07.2013 04:00, schrieb Jia Liu:
> We should free typename here.
>=20
> Signed-off-by: Jia Liu <proljc@gmail.com>
> ---
>  target-openrisc/cpu.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c
> index 6d40f1b..e348df0 100644
> --- a/target-openrisc/cpu.c
> +++ b/target-openrisc/cpu.c
> @@ -99,6 +99,7 @@ static ObjectClass *openrisc_cpu_class_by_name(const =
char *cpu_model)
> =20
>      typename =3D g_strdup_printf("%s-" TYPE_OPENRISC_CPU, cpu_model);
>      oc =3D object_class_by_name(typename);
> +    g_free(typename);
>      if (oc !=3D NULL && (!object_class_dynamic_cast(oc, TYPE_OPENRISC_=
CPU) ||
>                         object_class_is_abstract(oc))) {
>          return NULL;

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg