From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz86p-0008GF-46 for qemu-devel@nongnu.org; Tue, 16 Jul 2013 12:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz86n-0004JL-VJ for qemu-devel@nongnu.org; Tue, 16 Jul 2013 12:28:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz86n-0004J8-MZ for qemu-devel@nongnu.org; Tue, 16 Jul 2013 12:28:13 -0400 Message-ID: <51E57492.6010105@redhat.com> Date: Tue, 16 Jul 2013 10:28:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373355014-14846-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1373355014-14846-9-git-send-email-qiaonuohan@cn.fujitsu.com> <20130716024358.GD32278@stefanha-thinkpad.redhat.com> In-Reply-To: <20130716024358.GD32278@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2ANFADASPJCHEFRUHEFBE" Subject: Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, Qiao Nuohan , anderson@redhat.com, zhangxh@cn.fujitsu.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ANFADASPJCHEFRUHEFBE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/15/2013 08:43 PM, Stefan Hajnoczi wrote: > On Tue, Jul 09, 2013 at 03:30:13PM +0800, Qiao Nuohan wrote: >> if test "$seccomp" !=3D "no" ; then >> @@ -3872,6 +3914,14 @@ if test "$glx" =3D "yes" ; then >> echo "GLX_LIBS=3D$glx_libs" >> $config_host_mak >> fi >> =20 >> +if test "$lzo" =3D "yes" ; then >> + echo "CONFIG_LZO=3Dy" >> $config_host_mak >> +fi >> + >> +if test "$snappy" =3D "yes" ; then >> + echo "CONFIG_SNAPPY=3Dy" >> $config_host_mak >> +fi >=20 > Please also include a run-time check so QEMU can produce an error when = a > user chooses a compression algorithm which is not built in. For > example, the user should get a clear error when they select Snappy but > QEMU was built without Snappy support. Here's an instance where runtime introspection would come in handy - knowing which values of an enum are actually supportable, vs. the entire list of names but relying on decent errors for the elements that weren't compiled in. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2ANFADASPJCHEFRUHEFBE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR5XSSAAoJEKeha0olJ0Nqn7AIAKSV8+oHmSOLwQfHI1zoojLv gkyRg2wI6lkkej+20uihBKDJOEj7M8ai0l5VDS/wBtnFrLgWwFYsItw+OAmUO46Q Z8PYNigaQWggRRSGt7rANH4VgOeWIkxWRE2Lbt216Z5Ukg5rvvqS/k1G4COIF1cv 51acROE06ryuoY18O01EPeUYf7M7O9yuPuyifz0r0qXRQ/pM3Jwj693+kfUM7b5B vL/QXYwi6T/3oJ9TkkPsRlbDklECi0yrKN2dUZvj8akYOv1gXzqYdSc97AIC3Iij h5joYF4/Y7e/+4PL8CaQaFEXurbgUpe/Qmen1jRQ3KovPgdqOoxIsrx+XRKMMbw= =n8Xd -----END PGP SIGNATURE----- ------enig2ANFADASPJCHEFRUHEFBE--