From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzACV-0006h9-JZ
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 14:42:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzACR-0006Dv-Fn
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 14:42:15 -0400
Received: from mail-ye0-x22a.google.com ([2607:f8b0:4002:c04::22a]:41767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzACR-0006DH-9F
	for qemu-devel@nongnu.org; Tue, 16 Jul 2013 14:42:11 -0400
Received: by mail-ye0-f170.google.com with SMTP id q3so268987yen.1
	for <qemu-devel@nongnu.org>; Tue, 16 Jul 2013 11:42:10 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51E593FD.7040305@twiddle.net>
Date: Tue, 16 Jul 2013 11:42:05 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1373996700-29286-1-git-send-email-peter.maydell@linaro.org>
	<1373996700-29286-14-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1373996700-29286-14-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 13/13] configure: Make NPTL non-optional
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jia Liu <proljc@gmail.com>, patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Laurent Vivier <Laurent@vivier.eu>

On 07/16/2013 10:45 AM, Peter Maydell wrote:
> Now all linux-user targets support building with NPTL, we can make it
> mandatory. This is a good idea because:
>  * NPTL is no longer new and experimental; it is completely standard
>  * in practice, linux-user without NPTL is nearly useless for
>    binaries built against non-ancient glibc
>  * it allows us to delete the rather untested code for handling
>    the non-NPTL configuration
> 
> Note that this patch leaves the CONFIG_USE_NPTL ifdefs in the
> bsd-user codebase alone. This makes no change for bsd-user, since
> our configure test for NPTL had a "#include <linux/futex.h>"
> which means bsd-user would never have been compiled with
> CONFIG_USE_NPTL defined, and it still is not.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure              |   25 +++----------------------
>  include/exec/gdbstub.h |    2 +-
>  linux-user/main.c      |   43 -------------------------------------------
>  linux-user/mmap.c      |   11 -----------
>  linux-user/qemu.h      |   10 ----------
>  linux-user/syscall.c   |   47 +----------------------------------------------
>  6 files changed, 5 insertions(+), 133 deletions(-)
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~