From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOsf-0006YE-5e for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzOse-0004k3-9e for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOsd-0004ju-QO for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HAMh0f013790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 06:22:43 -0400 Message-ID: <51E67069.2010502@redhat.com> Date: Wed, 17 Jul 2013 12:22:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374053720-28420-1-git-send-email-stefanha@redhat.com> <1374053720-28420-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1374053720-28420-3-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] migration: notify migration state before starting thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Juan Quintela Il 17/07/2013 11:35, Stefan Hajnoczi ha scritto: > The migration thread runs outside the QEMU global mutex when possible. > Therefore we must notify migration state change *before* starting the > migration thread. > > This allows registered listeners to act before live migration iterations > begin. Therefore they can get into a state that allows for live > migration. When the migration thread starts everything will be ready. > > Signed-off-by: Stefan Hajnoczi > --- > migration.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/migration.c b/migration.c > index 9f5a423..b4daf13 100644 > --- a/migration.c > +++ b/migration.c > @@ -625,7 +625,9 @@ void migrate_fd_connect(MigrationState *s) > qemu_file_set_rate_limit(s->file, > s->bandwidth_limit / XFER_LIMIT_RATIO); > > + /* Notify before starting migration thread */ > + notifier_list_notify(&migration_state_notifiers, s); > + > qemu_thread_create(&s->thread, migration_thread, s, > QEMU_THREAD_JOINABLE); > - notifier_list_notify(&migration_state_notifiers, s); > } > Acked-by: Paolo Bonzini