From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOsM-0006E8-2f for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzOsJ-0004gR-79 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzOsI-0004gE-VQ for qemu-devel@nongnu.org; Wed, 17 Jul 2013 06:22:23 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HAMLUF001083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 06:22:22 -0400 Message-ID: <51E670F0.7050703@redhat.com> Date: Wed, 17 Jul 2013 12:24:48 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1374055057-31988-1-git-send-email-famz@redhat.com> In-Reply-To: <1374055057-31988-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 07/17/13 11:57, Fam Zheng wrote: > s->qcow and s->qcow_filename are allocated but not freed on error. Fix the > possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of > bdrv_create() and also the one of enable_write_target(). > > Signed-off-by: Fam Zheng > --- > > v2: Fix leak of s->qcow_filename, propagate returen value of > enable_write_target(). [Laszlo] > > --- > block/vvfat.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) Looks good to me. Reviewed-by: Laszlo Ersek