From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzPgG-0000cx-Ov for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzPgF-0005wA-Mb for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:14:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzPgF-0005vw-EW for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:13:59 -0400 Message-ID: <51E67C5C.1010903@redhat.com> Date: Wed, 17 Jul 2013 13:13:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374053373-30499-1-git-send-email-gaowanlong@cn.fujitsu.com> <1374053373-30499-3-git-send-email-gaowanlong@cn.fujitsu.com> In-Reply-To: <1374053373-30499-3-git-send-email-gaowanlong@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 02/12] NUMA: split -numa option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wanlong Gao Cc: aliguori@us.ibm.com, ehabkost@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, peter.huangpeng@huawei.com, afaerber@suse.de Il 17/07/2013 11:29, Wanlong Gao ha scritto: > Change -numa option like following as Paolo suggested: > -numa node,nodeid=0,cpus=0-1 \ > -numa mem,nodeid=0,size=1G > > This new option will make later coming memory hotplug better. > And this new option is implemented using OptsVisitor. It shouldn't be changed. The old "mem" suboption should remain valid (as legacy), and it should be equivalent to a separate "-numa mem" argument. Never, ever break existing command lines. Paolo