From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzPhW-0001zo-Dz for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:15:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzPhV-0006pJ-42 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:15:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzPhU-0006nS-Th for qemu-devel@nongnu.org; Wed, 17 Jul 2013 07:15:17 -0400 Message-ID: <51E67CA6.1030908@redhat.com> Date: Wed, 17 Jul 2013 13:14:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1374053373-30499-1-git-send-email-gaowanlong@cn.fujitsu.com> <1374053373-30499-3-git-send-email-gaowanlong@cn.fujitsu.com> <51E6795E.4000706@redhat.com> In-Reply-To: <51E6795E.4000706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 02/12] NUMA: split -numa option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: aliguori@us.ibm.com, ehabkost@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, afaerber@suse.de, Wanlong Gao Il 17/07/2013 13:00, Laszlo Ersek ha scritto: > Hm, I think that's actually supported, the user can pass > > -numa node,nodeid=1,cpus=1-2 -numa node,nodeid=1,cpus=5-6 > > and the bitmask will be the union. > > If that's the case, opts-visitor would support the following notation > too (you'd have to turn "cpus" into a list of strings): > > -numa node,nodeid=1,cpus=1-2,cpus=5-6 > > But I'm not sure if that's the intent and/or if it would be worth the churn. It is the intent, and it would be worth the churn. :) Excellent review! Paolo