From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzQmy-0008BU-C3 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzQmv-0005un-QT for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:25:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzQmv-0005uM-Gk for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:24:57 -0400 Message-ID: <51E68D0F.4040503@redhat.com> Date: Wed, 17 Jul 2013 06:24:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374053373-30499-1-git-send-email-gaowanlong@cn.fujitsu.com> <1374053373-30499-2-git-send-email-gaowanlong@cn.fujitsu.com> <51E67368.3000003@redhat.com> In-Reply-To: <51E67368.3000003@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LLRUBHEJPGCIWPMTKKOG" Subject: Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: aliguori@us.ibm.com, ehabkost@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, afaerber@suse.de, Wanlong Gao This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LLRUBHEJPGCIWPMTKKOG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2013 04:35 AM, Laszlo Ersek wrote: >> +# @cpus: #optional VCPUs belong to this node >> +# >> +# Since: 1.6 >> +## >> +{ 'type': 'NumaNodeOptions', >> + 'data': { >> + '*nodeid': 'int', >> + '*cpus': 'str' }} >> + >=20 > Should we document the format for "cpus" here too? Not only that, but is this even the right representation? The fact that you are requiring the receiver to further parse this string means you probably represented it at the wrong level in JSON. That is, a JSON string "1,2,4" requires post-processing to turn it into 3 processor ids, while a JSON array [1, 2, 4] does not, so you should probably consider '*cpus':['int'] as your preferred datatype. >> +# Since 1.6 >> +## >> +{ 'type': 'NumaMemOptions', >> + 'data': { >> + '*nodeid': 'int', >> + '*size': 'size' }} >> >=20 > Looks good in general but I'm not sure if hardware tabs are allowed (or= > usual) in this file. Drop the tabs. Also, this missed soft freeze for 1.6, so you will probably end up using Since 1.7 by the time it actually gets accepted. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2LLRUBHEJPGCIWPMTKKOG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR5o0PAAoJEKeha0olJ0NqgwIIAK3SlQYLv86zkDbNF/ZiwBLw JY4omDnnxWvZjg1rKlsR6RIM4V/wwHen+1zSWtdhiyJkAHyD1VotXHootC4bMbwY /MvSpCfFKBoAH5b9POTCLSjmxLD7fz3P4uSCZWUZAgCxhFaVzmUOs7GOq26nVxHD A3y5DxVu8mzQk81mECxZsZl3nJqmOvzFPbQje39g+qm50iPYFcvbMVzN8MO04ZvG MFP4uQANslxwuUPHiQWs2v7mbbaCuMetGweQJkHaQy7jCeqSGkYlAdF7QsdjRNbf 9jvGTwEZHB0KGs2P9XHsSSBW9B/6P6geL4WqtiOZrJnPDOQ+oc0lCLdMXQUjM90= =rHDe -----END PGP SIGNATURE----- ------enig2LLRUBHEJPGCIWPMTKKOG--