From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzR66-0000u6-8e for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:44:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzR64-0005Li-Qs for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:44:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzR64-0005Le-HU for qemu-devel@nongnu.org; Wed, 17 Jul 2013 08:44:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HCihmK015355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Jul 2013 08:44:43 -0400 Message-ID: <51E691B9.5020605@redhat.com> Date: Wed, 17 Jul 2013 06:44:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374054136-28741-1-git-send-email-famz@redhat.com> <1374054136-28741-12-git-send-email-famz@redhat.com> In-Reply-To: <1374054136-28741-12-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WNIGNXEBKUOUCRUXXDFP" Subject: Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WNIGNXEBKUOUCRUXXDFP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2013 03:42 AM, Fam Zheng wrote: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. >=20 > Signed-off-by: Fam Zheng > --- > blockdev.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 22 ++++++++++++++++++ > 3 files changed, 142 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -1665,6 +1665,40 @@ > '*on-target-error': 'BlockdevOnError' } } > =20 > ## > +# @BlockdevBackup > +# > +{ 'type': 'BlockdevBackup', > + 'data': { 'device': 'str', 'target': 'str', > + 'sync': 'MirrorSyncMode', > + '*speed': 'int', > + '*on-source-error': 'BlockdevOnError', > + '*on-target-error': 'BlockdevOnError' } } Seems okay. But what is missing is the addition of this type into the union used for 'transaction' - shouldn't it be possible to mix this with other transaction capabilities? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WNIGNXEBKUOUCRUXXDFP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR5pG5AAoJEKeha0olJ0NqCvkH/izdA7OggO9DxSZNlsXHl9Wn QP37JUU7oeNG9YC/VY6bAq1iqxBriQal/pPL4RSoWHHWgUqhrWZYfQcaZvxj7Vx7 38g2brFTjagM6b9jsxEAFsuW9AVdBVnn6h/HsVs7yM5qSSp9c0jh1lsKDs8a8b8U e6iU+K8vEC6LYeXiB/kDiLWP5DIxb3DXdK5JK7vRwiRYtGJo1MJbGuNr3gDEWbzy KgPxIKIn+ZvSMeK+f2Hz3tAKGq3Zeo1gpp44ekYk9dpeSIJUV3FkQJO2x11Wul1s iMsbi5IDQltiVwuYY9+TnP+OThU0wyeyaem4aVbO8mz0JLE4l1KTZjxZwoMZeBM= =/bVI -----END PGP SIGNATURE----- ------enig2WNIGNXEBKUOUCRUXXDFP--