From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzTIx-0002Lx-Q1 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzTIv-0000Na-Ow for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:06:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzTIv-0000NF-Gm for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:06:09 -0400 Message-ID: <51E6B2CF.2020603@redhat.com> Date: Wed, 17 Jul 2013 17:05:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1373544987-20613-1-git-send-email-pl@kamp.de> In-Reply-To: <1373544987-20613-1-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 11/07/2013 14:16, Peter Lieven ha scritto: > this series adds logical block provisioning functions to the iscsi layer. > it also is the first step to the change of migration to coroutines in > block/iscsi. > > the changes to qemu-img and block migration have been split and will > follow in separte patches later. > > changes in v3: > - merge both block provision inquiries into one patch. explitely free the iscsi tasks after > the inquiry. limit the unmap to 128k blocks if the target returns max_unmap = 0xffffffff; > - in the coroutine framework free the scsi task in the caller not in the callback. also > change the iTask init as Kevin suggested. > - in iscsi_co_is_allocated() return unallocated only for ANCHORED and UNALLOACTED to avoid > a wrong return value if a new provisioning status is introduced. > - added new patch adding .bdrv_co_discard > - build .bdrv_co_write_zeroes on top of .bdrv_co_discard > - fixed a bug for -ENOSPC in iscsi_create() spotted by Kevin. > - remove support for misaligned nb_sectors in aio_readv > - add log message in error case to lun alignment checks > > Peter Lieven (10): > iscsi: add logical block provisioning information to iscsilun > iscsi: add .bdrv_co_is_allocated > iscsi: add .bdrv_co_discard > iscsi: add .bdrv_write_zeroes > block: add bdrv_write_zeroes() > block/raw: add bdrv_co_write_zeroes > iscsi: fix -ENOSPC in iscsi_create() > iscsi: factor out sector conversions > iscsi: remove support for misaligned nb_sectors in aio_readv > iscsi: assert that sectors are aligned to LUN blocksize > > block.c | 27 ++- > block/iscsi.c | 433 +++++++++++++++++++++++++++++++++++++------------ > block/raw.c | 8 + > include/block/block.h | 2 + > 4 files changed, 358 insertions(+), 112 deletions(-) > Applied 7-10 to scsi-next, please rebase/resubmit the others (possibly together with the qemu-img convert patches). Paolo