From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzTHi-0001yX-9y for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:04:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzTHe-000840-Q3 for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:04:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzTHe-00083S-FX for qemu-devel@nongnu.org; Wed, 17 Jul 2013 11:04:50 -0400 Message-ID: <51E6B314.8080506@redhat.com> Date: Wed, 17 Jul 2013 17:07:00 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1373464153-18979-1-git-send-email-mst@redhat.com> <1373464153-18979-9-git-send-email-mst@redhat.com> In-Reply-To: <1373464153-18979-9-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , qemu-devel@nongnu.org, Aurelien Jarno On 07/10/13 15:51, Michael S. Tsirkin wrote: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. > > Signed-off-by: Michael S. Tsirkin > --- > hw/acpi/ich9.c | 7 ++++++- > hw/acpi/piix4.c | 44 +++++++++++++++++++++++++++++++++++++++++++- > hw/i386/Makefile.objs | 2 ++ > hw/i386/pc.c | 41 +++++++++++++++++++++++++++++++++++++++-- > hw/i386/pc_piix.c | 15 ++++++++++++--- > hw/i386/pc_q35.c | 10 +++++++--- > hw/isa/lpc_ich9.c | 11 +++++++++-- > hw/mips/mips_malta.c | 2 +- > hw/misc/pvpanic.c | 12 +++++++----- > hw/pci-host/q35.c | 1 + > include/hw/acpi/ich9.h | 2 +- > include/hw/i386/ich9.h | 3 ++- > include/hw/i386/pc.h | 37 ++++++++++++++++++++++++++++++++++--- > 13 files changed, 164 insertions(+), 23 deletions(-) So we won't be fishing in a global pool of information at ACPI table creation time as I had expected / advertized before. Instead any required bits are gradually collected into the guest info structure while creating / configuring the machine. This is likely a better approach; the set of dependencies for all ACPI tables together are tracked explicitly in guest info. Also, we don't collect the bits from the outside, breaching encapsulation of devices; devices publish the bits. Reviewed-by: Laszlo Ersek