From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzVv6-0003AP-5t for qemu-devel@nongnu.org; Wed, 17 Jul 2013 13:53:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzVv4-0005Ou-TZ for qemu-devel@nongnu.org; Wed, 17 Jul 2013 13:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzVv4-0005On-Kb for qemu-devel@nongnu.org; Wed, 17 Jul 2013 13:53:42 -0400 Message-ID: <51E6DA24.1070503@redhat.com> Date: Wed, 17 Jul 2013 11:53:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374081369-1511-1-git-send-email-armbru@redhat.com> <1374081369-1511-2-git-send-email-armbru@redhat.com> In-Reply-To: <1374081369-1511-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EHLKSDHGLHOVEVOXRHEE" Subject: Re: [Qemu-devel] [PATCH 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, lersek@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EHLKSDHGLHOVEVOXRHEE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2013 11:16 AM, Markus Armbruster wrote: > It exits on all error conditions but one, where it returns -1. > Normalize, and return void. >=20 > Signed-off-by: Markus Armbruster > --- > arch_init.c | 4 +--- > hw/i386/smbios.c | 10 +++++----- > include/hw/i386/smbios.h | 2 +- > 3 files changed, 7 insertions(+), 9 deletions(-) >=20 > @@ -242,5 +242,5 @@ int smbios_entry_add(const char *t) > } > =20 > error_report("Must specify type=3D or file=3D"); > - return -1; > + exit(1); I hate magic numbers; wouldn't exit(EXIT_FAILURE) be more explicit at your intent? At any rate, you're not the first person to use exit(1), so= : Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2EHLKSDHGLHOVEVOXRHEE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR5tokAAoJEKeha0olJ0NqU48H/1dxdZKxQX2OmAVSvPvnF5jV OwQsl3yaNs2y/cR5RXi9nr5PybbXlW5GUnz0rLSVzjew++Ep3A84NCn74gmVmCcT kmQek3m1rBnISUGMc5TIgq303IfqKQWduq8HTSPdjZxNoiHYcf83LFJs4oBgXk/u UiVUUDk1J0wFLSn98CNKwk449j+grkmeZ855XF9NHlN4FfXm/7jqlj6TZt6Bpha4 +PDJHjnHRJjsN5wxq6addrQjtBjVId0/tnGVKllVg9z729tE7q4FlhMXrvgCYnRc d9zeG6G0D+rOG8bwrrcpHlKpD8XZ3hZY62veAkX+G0VpTgbPL53xY+xsb/J0CfE= =Bdsz -----END PGP SIGNATURE----- ------enig2EHLKSDHGLHOVEVOXRHEE--