From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UzWun-0001BP-Nx
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 14:57:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UzWum-0004G9-On
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 14:57:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UzWum-0004G4-Ge
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 14:57:28 -0400
Message-ID: <51E6E90D.9050300@redhat.com>
Date: Wed, 17 Jul 2013 20:57:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1373840171-25556-1-git-send-email-rth@twiddle.net>
	<1373840171-25556-4-git-send-email-rth@twiddle.net>
	<8761w9wm50.fsf@blackfin.pond.sub.org>
	<51E67B7A.8000800@redhat.com> <8761w9gp88.fsf@codemonkey.ws>
	<51E6D54B.7020700@redhat.com> <51E6E1CE.5080609@twiddle.net>
In-Reply-To: <51E6E1CE.5080609@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in
	address_space_rw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Il 17/07/2013 20:26, Richard Henderson ha scritto:
> On 07/17/2013 10:32 AM, Paolo Bonzini wrote:
>> My patch works.
> 
> You patch doesn't crash for this device, which isn't quite the same thing.
> 
> But it's certainly no worse than we had before my patch, so I'll not object so
> long as a fixme sort of comment is installed too.

I'm still not sure what the bug is (so what the FIXME comment would
be)... except of course that there may be bug in access_with_adjusted_size.

Paolo