From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzXOe-0004gZ-Rs for qemu-devel@nongnu.org; Wed, 17 Jul 2013 15:28:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzXOa-0006jj-5n for qemu-devel@nongnu.org; Wed, 17 Jul 2013 15:28:20 -0400 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:56195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzXOa-0006jP-0v for qemu-devel@nongnu.org; Wed, 17 Jul 2013 15:28:16 -0400 Received: by mail-qc0-f177.google.com with SMTP id n1so1291479qcx.36 for ; Wed, 17 Jul 2013 12:28:15 -0700 (PDT) Sender: Richard Henderson Message-ID: <51E6F046.6060900@twiddle.net> Date: Wed, 17 Jul 2013 12:28:06 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1373840171-25556-1-git-send-email-rth@twiddle.net> <1373840171-25556-4-git-send-email-rth@twiddle.net> <8761w9wm50.fsf@blackfin.pond.sub.org> <51E67B7A.8000800@redhat.com> <8761w9gp88.fsf@codemonkey.ws> <51E6D54B.7020700@redhat.com> <51E6E1CE.5080609@twiddle.net> <51E6E90D.9050300@redhat.com> In-Reply-To: <51E6E90D.9050300@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Anthony Liguori , Gerd Hoffmann , Markus Armbruster , qemu-devel@nongnu.org On 07/17/2013 11:57 AM, Paolo Bonzini wrote: > I'm still not sure what the bug is (so what the FIXME comment would > be)... except of course that there may be bug in access_with_adjusted_size. The code here in exec.c is not using access_with_adjusted_size. Unfortunately, access_with_adjusted_size only handles single copies, one direction at a time. We're attempting a sort of "memcpy", which calls for some amount of caching across the loop... r~