From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50605)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzXyt-00086y-QQ
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:05:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzXyr-0004ev-2J
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:05:47 -0400
Received: from mail-qe0-x231.google.com ([2607:f8b0:400d:c02::231]:48181)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UzXyq-0004eo-Ra
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 16:05:44 -0400
Received: by mail-qe0-f49.google.com with SMTP id cz11so1363910qeb.36
	for <qemu-devel@nongnu.org>; Wed, 17 Jul 2013 13:05:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51E6F914.1050300@twiddle.net>
Date: Wed, 17 Jul 2013 13:05:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1373840171-25556-1-git-send-email-rth@twiddle.net>
	<1373840171-25556-4-git-send-email-rth@twiddle.net>
	<8761w9wm50.fsf@blackfin.pond.sub.org>
	<51E67B7A.8000800@redhat.com> <8761w9gp88.fsf@codemonkey.ws>
	<51E6D54B.7020700@redhat.com> <51E6E1CE.5080609@twiddle.net>
	<51E6E90D.9050300@redhat.com> <51E6F046.6060900@twiddle.net>
	<51E6F6FD.5060208@redhat.com>
In-Reply-To: <51E6F6FD.5060208@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in
	address_space_rw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 07/17/2013 12:56 PM, Paolo Bonzini wrote:
> It is:
> 
> cpu_outb
> -> address_space_write
> -> address_space_rw
> -> io_mem_write
> -> memory_region_dispatch_write
> -> access_with_adjusted_size
> 
> memory_access_size is just returning a length that makes sense when
> passed to io_mem_write and ultimately to access_with_adjusted_size.

Ah, ok.  Sorry for being dense about the full context here.

I agree ignoring impl.minimum is ok here, since a real assert ought
to be lower down in access_with_adjusted_size, right before actually
dispatching to the device code.


r~