From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UznEz-0001E3-BQ for qemu-devel@nongnu.org; Thu, 18 Jul 2013 08:23:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UznEu-0007a6-D6 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 08:23:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UznEu-0007Zz-4f for qemu-devel@nongnu.org; Thu, 18 Jul 2013 08:23:20 -0400 Message-ID: <51E7DE23.600@redhat.com> Date: Thu, 18 Jul 2013 14:22:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1373993306-25764-1-git-send-email-mrhines@linux.vnet.ibm.com> <1373993306-25764-5-git-send-email-mrhines@linux.vnet.ibm.com> <1374132600.2000.12.camel@localhost.localdomain> <51E7DA71.2040400@linux.vnet.ibm.com> In-Reply-To: <51E7DA71.2040400@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, Marcel Apfelbaum , gokul@us.ibm.com, chegu_vinod@hp.com Il 18/07/2013 14:07, Michael R. Hines ha scritto: > On 07/18/2013 03:30 AM, Marcel Apfelbaum wrote: >> On Tue, 2013-07-16 at 12:48 -0400, mrhines@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> Code that does need to be visible is kept >>> well contained inside this file and this is the only >>> new additional file to the entire patch. >>> >>> This file includes the entire protocol and interfaces >>> required to perform RDMA migration. >>> >>> Also, the configure and Makefile modifications to link >>> this file are included. >>> >>> Full documentation is in docs/rdma.txt >>> >> This patch is too big (in my opinion). >> I would split it into at least 3 patches: >> 1. Generic RDMA code (this part can be reused by everyone who will >> need RDMA in the future) >> 2. RDMA transfer protocol (separating this will give us possibility >> for optimization without touching the rest of the code) >> 3. Migration related code >> > > Don't let the "v3" mislead you =). The patch actually *used* to look > just like what > you described (3 different ones), but after more than a dozen reviews > since January > I was told to join all the code into a single file by the reviewers. Yeah, I guess I owe some explanation to Marcel (who is not RDMA-impaired at all). Because the reviewers (me especially) did not know much about RDMA, we initially concentrated on having the right interfaces between migration-rdma.c and the migration core. Once we had something that core developers considered to be the "right" interfaces, Michael's original split in 1/2/3 didn't make much sense anymore, so in the end it was easier to just merge everything in a single patch and treat it almost as a black box. Having generic RDMA code in a separate file would be a nice thing, but I don't think it's absolutely necessary in order to merge this code (which I would like to have in 1.6). We have already done "chainsaw" passes on files in the past, at this point I prefer "release early, release often". Paolo