From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UzqMg-00041i-It
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:43:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UzqMa-000247-Tu
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:43:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UzqMa-00023h-DK
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 11:43:28 -0400
Message-ID: <51E80DA8.1080803@redhat.com>
Date: Thu, 18 Jul 2013 17:45:44 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1374155964-11278-1-git-send-email-lersek@redhat.com>
	<1374155964-11278-2-git-send-email-lersek@redhat.com>
	<51E8017C.2000900@redhat.com>
In-Reply-To: <51E8017C.2000900@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, gaowanlong@cn.fujitsu.com

On 07/18/13 16:53, Paolo Bonzini wrote:
> Il 18/07/2013 15:59, Laszlo Ersek ha scritto:

>> +    default:
>> +        assert(0);
> 
> "abort()" to avoid excessively punishing folks who use -DNDEBUG (and
> also to ensure they do not get extra compiler warnings).
> 
> Otherwise looks good!

Yeah I hesitated between these two. Will fix.

Thanks,
Laszlo