From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzrrn-0002pb-6U for qemu-devel@nongnu.org; Thu, 18 Jul 2013 13:19:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uzrrl-0003qD-13 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 13:19:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzrrk-0003q9-Pd for qemu-devel@nongnu.org; Thu, 18 Jul 2013 13:19:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IHJi0t013292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 13:19:44 -0400 Message-ID: <51E823AF.6060200@redhat.com> Date: Thu, 18 Jul 2013 11:19:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374091462-18391-1-git-send-email-imain@redhat.com> <1374091462-18391-2-git-send-email-imain@redhat.com> In-Reply-To: <1374091462-18391-2-git-send-email-imain@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HDWcNrNCL4EkXoNmGlHSLAuDEabLI7LE0" Subject: Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HDWcNrNCL4EkXoNmGlHSLAuDEabLI7LE0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/17/2013 02:04 PM, Ian Main wrote: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NONE and TOP modes of synchronization. >=20 > FULL performs as before copying the entire contents of the drive > while preserving the point-in-time using CoW. > NONE only copies new writes to the target drive. > TOP copies changes to the topmost drive image and preserves the > point-in-time using CoW. >=20 > +++ b/qapi-schema.json > @@ -1807,6 +1807,10 @@ > # @format: #optional the format of the new destination, default is to > # probe if @mode is 'existing', else the format of the source= > # > +# @sync: what parts of the disk image should be copied to the destinat= ion > +# (all the disk, only the sectors allocated in the topmost imag= e, or > +# only new I/O). > +# > # @mode: #optional whether and how QEMU should create a new image, def= ault is > # 'absolute-paths'. This hunk looks bogus; the 'DriveBackup' type already documents @sync as of commit b53169e, which makes me suspect this hunk got misapplied during rebasing. > # > diff --git a/qmp-commands.hx b/qmp-commands.hx > index e075df4..f3f6b3d 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -957,6 +957,7 @@ Arguments: > =20 > Example: > -> { "execute": "drive-backup", "arguments": { "device": "drive0", > + "sync": "full", > "target": "backup.img" = } } Ouch - commit b53169e made 'sync' mandatory, but forgot to update the example to match; perhaps this hunk ought to be applied independently? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HDWcNrNCL4EkXoNmGlHSLAuDEabLI7LE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6COvAAoJEKeha0olJ0NqdlIH/0HyND6mUEUjob2Uig+t/ShT LyEwgpDu+JfLtzknvBJVHFBjbcn+fvBxKIRejEywJnxHlII4gMI1GeKSXYCR2SiF le2QdC9UbKcfg688EF02rbEw80kfZrbhai4VTO9LiuaiAKKE6BfT7S21INEPtwaF ZbzNDrm4tsilX2kvpT6/RPlBaqjWdzvocJEGkiJQEY5TBKFCuEizWliQc0dK/U0q 8bchp+dmpSKstpnaIg5ngpLodHzgLL4Z0v/XV/QlWLB+VUF6HuV6G5ArTde3+upG /Odkb+F7khX5H721tbM8mlya7RF64SCEZ1UQxNGfoufMoA+nR3w4ihzfAa+H3HE= =6HGO -----END PGP SIGNATURE----- --HDWcNrNCL4EkXoNmGlHSLAuDEabLI7LE0--