From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztNm-0002zV-GL for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:56:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UztNl-00051M-Br for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:56:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztNl-00051F-3u for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:56:53 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IIuqvL031659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 14:56:52 -0400 Message-ID: <51E83A73.9070501@redhat.com> Date: Thu, 18 Jul 2013 12:56:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374173251-19449-1-git-send-email-imain@redhat.com> In-Reply-To: <1374173251-19449-1-git-send-email-imain@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f6Q8pv3v4pwAted2c7hVFJAHKrhV502R1" Subject: Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f6Q8pv3v4pwAted2c7hVFJAHKrhV502R1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 12:47 PM, Ian Main wrote: > qcow2 supports backing files so it makes sense to default to qcow2 > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE= > breaks tests but that could be fixed if we wanted it. >=20 > Signed-off-by: Ian Main > --- > blockdev.c | 5 ++++- > qapi-schema.json | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) Looks okay, but let's answer the meta-question first of whether we should just make 'format' mandatory and be done with it. Also, I've noticed you aren't cc'ing many people; that can slow down reviews. http://wiki.qemu.org/Contribute/SubmitAPatch gives hints on how to determine the right people to send your patches to, by deciphering MAINTAINERS and running ./scripts/getmaintainer.pl. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f6Q8pv3v4pwAted2c7hVFJAHKrhV502R1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6DpzAAoJEKeha0olJ0NqPV0IAK06RwRCwogwBAx8AL8KrWCW 62AFPU4gkTNu2iJOGonWvhelJYzE+I6VTG4UYC5hpWs8xXg0MkTxmc+N7JsRJmK+ BhsfdsTBg46cMP+LYqe1dsSJ8blCpw8z9e+tgCavpp1nU79VElJ2xK9OgwaZ8BYN zJe5N+bKfBmyOhHJbt8j/JJIwew4dmxz4AhoUc6UAZdKsDfMq2vEXa4E/t1LuRQz SAFYtAZUQgnu1YaPbtidd9D5yrdip4BftZBg3ndVHxdx2iVr3BV5fy3Pje0M74Mj 2hb/YuV/b7/7ZXt5R6CwCFacVGL1q26Q7qAh4V6rq0UKs0yY2244wklqaEvCvoA= =wpq9 -----END PGP SIGNATURE----- --f6Q8pv3v4pwAted2c7hVFJAHKrhV502R1--