From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzuHo-0005Zw-S1 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzuHn-0008Dx-D1 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:54:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzuHn-0008Dq-6I for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:54:47 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IJskRQ020660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 15:54:46 -0400 Message-ID: <51E84805.8030701@redhat.com> Date: Thu, 18 Jul 2013 13:54:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374091462-18391-1-git-send-email-imain@redhat.com> <1374091462-18391-2-git-send-email-imain@redhat.com> <51E823AF.6060200@redhat.com> <20130718190651.GC13675@gate.mains.priv> In-Reply-To: <20130718190651.GC13675@gate.mains.priv> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dFko5RF2JpNhVVnkLrqodCTbKsUx0u4xD" Subject: Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dFko5RF2JpNhVVnkLrqodCTbKsUx0u4xD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 01:06 PM, Ian Main wrote: > On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote: >> On 07/17/2013 02:04 PM, Ian Main wrote: >>> This patch adds sync-modes to the drive-backup interface and >>> implements the FULL, NONE and TOP modes of synchronization. >>> >>> @@ -1807,6 +1807,10 @@ >>> # @format: #optional the format of the new destination, default is t= o >>> # probe if @mode is 'existing', else the format of the sour= ce >>> # >>> +# @sync: what parts of the disk image should be copied to the destin= ation >>> +# (all the disk, only the sectors allocated in the topmost im= age, or >>> +# only new I/O). >>> +# >>> # @mode: #optional whether and how QEMU should create a new image, d= efault is >>> # 'absolute-paths'. >> >> This hunk looks bogus; the 'DriveBackup' type already documents @sync = as >> of commit b53169e, which makes me suspect this hunk got misapplied >> during rebasing. >=20 > Did you check that? I know there was one bit of documentation missing > that I fixed here. I also just did a clean rebase (git am) to > kevin/block and it all applied fine. Yes, it _applied_ fine, because of git's insistence on applying hunks regardless of line fuzzing. It probably applied to 'drive-mirror', since I see this context in the section for 'drive-mirror' when reading the unpatched file at current qemu.git head: > # @format: #optional the format of the new destination, default is to > # probe if @mode is 'existing', else the format of the source > # > # @mode: #optional whether and how QEMU should create a new image, defa= ult is > # 'absolute-paths'. > # Hence, my argument that you DON'T want this hunk. >>> Example: >>> -> { "execute": "drive-backup", "arguments": { "device": "drive0", >>> + "sync": "full", >>> "target": "backup.img= " } } >> >> Ouch - commit b53169e made 'sync' mandatory, but forgot to update the >> example to match; perhaps this hunk ought to be applied independently?= >=20 > That's up to you guys, I can split it out if needed. I don't care either way as long as it gets fixed before 1.6; it all depends on how long the review of the rest of your series takes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dFko5RF2JpNhVVnkLrqodCTbKsUx0u4xD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6EgFAAoJEKeha0olJ0Nq7SMH/inXhctcsVdOGiH0V+KQVezP okIQpRoaerBPn3AiG/7rev65PIEWTfz/fZYoeyI/NIo8G/HC9zUCR7Cg5gKQzVr5 oEv0KkDc4ReH7H6v9iqNuJVvlrf04SV+0Trvy2bTShPyiGRFJXleXGBL+sZitNqu b5Jj51RjI2u3njACjYTXYujLDY1zFSA6p4IWVn71rRTBT6kwm3Y/ljgx/EAVUBbt 7Fewn44zu6EDt2YhVD/9afOTGRsikWRLTTycdZsQbaxxiQhK5qTYVnSrNd8rnvVx TLxlpiPT7CuQ/pBDdCDZgDBzZqheQcw1D0SgmP+5kqum/b5cdtJchUCfbJubKYg= =fqvi -----END PGP SIGNATURE----- --dFko5RF2JpNhVVnkLrqodCTbKsUx0u4xD--