From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzuIl-0006Wl-9x for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:55:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzuIj-0000Tz-9l for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:55:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzuIi-0000Te-Jx for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:55:44 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IJthkL017660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 15:55:43 -0400 Message-ID: <51E8483E.2000308@redhat.com> Date: Thu, 18 Jul 2013 13:55:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374173251-19449-1-git-send-email-imain@redhat.com> <51E83A73.9070501@redhat.com> <20130718191344.GD13675@gate.mains.priv> In-Reply-To: <20130718191344.GD13675@gate.mains.priv> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c8ce6lNic2mhPxnVvsOCESbAQsG3LtTOn" Subject: Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c8ce6lNic2mhPxnVvsOCESbAQsG3LtTOn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 01:13 PM, Ian Main wrote: > On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote: >> On 07/18/2013 12:47 PM, Ian Main wrote: >>> qcow2 supports backing files so it makes sense to default to qcow2 >>> for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing >>> drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NO= NE >>> breaks tests but that could be fixed if we wanted it. >>> >>> Signed-off-by: Ian Main >>> --- >>> blockdev.c | 5 ++++- >>> qapi-schema.json | 1 + >>> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> Looks okay, but let's answer the meta-question first of whether we >> should just make 'format' mandatory and be done with it. >> >> Also, I've noticed you aren't cc'ing many people; that can slow down >> reviews. http://wiki.qemu.org/Contribute/SubmitAPatch gives hints on >> how to determine the right people to send your patches to, by >> deciphering MAINTAINERS and running ./scripts/getmaintainer.pl. >=20 > Ah ok, I'll add them next rev. >=20 > My take has been to just do a patch that implements the suggestion and > see what people think :). But this list is so high volume that the people that matter won't check your email unless they are cc'd :) If you want opinions fast, it pays to follow the directions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --c8ce6lNic2mhPxnVvsOCESbAQsG3LtTOn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6Eg+AAoJEKeha0olJ0NqBlgH/31JmJShwJiAOo6o+WBDAkDn uor30/f8JNWDJPxe9iYzv9vZwSWZIt8BRqI225CZCDiNG96rhyAJ/CdZD7JeIu2b JIpEzhkhVIaQArdtqjw1eXinxwFZ+JA5S0kMaO1vCRXCOPOb0DYVaaIiXxb3DUxl 3m0ILjlcGvbbfguPdQH2Uhi0K0++bMvh9jzh/1oENgb+jD5QkyvZo3pkfqUUVyv1 QNWmdgpo4xVpkS0hTMVm4berA+4EXo+h5gWtGGbankpeXPCnKLBWvJKiC4y32k3N UiGi+tGOasaxCxker+DDKQkuZotTmIY8ZjDIfN/bNzs3km6dGDczxVk2DcNGIBk= =V2gH -----END PGP SIGNATURE----- --c8ce6lNic2mhPxnVvsOCESbAQsG3LtTOn--