From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V07kT-00028L-7v for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V07kR-0001jq-2a for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:17:17 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:42359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V07kQ-0001in-BU for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:17:14 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jul 2013 15:38:51 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id AB1723940058 for ; Fri, 19 Jul 2013 15:47:03 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6JAHrbp28508376 for ; Fri, 19 Jul 2013 15:47:53 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6JAH7Tq021038 for ; Fri, 19 Jul 2013 20:17:07 +1000 Message-ID: <51E91217.1090202@linux.vnet.ibm.com> Date: Fri, 19 Jul 2013 18:16:55 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374054136-28741-1-git-send-email-famz@redhat.com> <1374054136-28741-12-git-send-email-famz@redhat.com> <51E691B9.5020605@redhat.com> <20130718044138.GA29052@T430s.nay.redhat.com> In-Reply-To: <20130718044138.GA29052@T430s.nay.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com 于 2013-7-18 12:41, Fam Zheng 写道: > On Wed, 07/17 06:44, Eric Blake wrote: >> On 07/17/2013 03:42 AM, Fam Zheng wrote: >>> Similar to drive-backup, but this command uses a device id as target >>> instead of creating/opening an image file. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> blockdev.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++ >>> qmp-commands.hx | 22 ++++++++++++++++++ >>> 3 files changed, 142 insertions(+) >>> >> >>> +++ b/qapi-schema.json >>> @@ -1665,6 +1665,40 @@ >>> '*on-target-error': 'BlockdevOnError' } } >>> >>> ## >>> +# @BlockdevBackup >>> +# >> >>> +{ 'type': 'BlockdevBackup', >>> + 'data': { 'device': 'str', 'target': 'str', >>> + 'sync': 'MirrorSyncMode', >>> + '*speed': 'int', >>> + '*on-source-error': 'BlockdevOnError', >>> + '*on-target-error': 'BlockdevOnError' } } >> >> Seems okay. But what is missing is the addition of this type into the >> union used for 'transaction' - shouldn't it be possible to mix this with >> other transaction capabilities? >> > > Should be possible, as users may want point-in-time snapshot of multiple > disks. If this API looks OK, I will include it into transaction in the > next version. > Instead of add this new API, how about extend Driver-backup API? This patch is basically doing similar things with driver-backup, extension of old API will save trouble to do same things driver-backup already does, such as support qmp_transaction. -- Best Regards Wenchao Xia