From: Eric Blake <eblake@redhat.com>
To: Pawit Pornkitprasan <p.pawit@gmail.com>
Cc: Ryousei Takano <takano-ryousei@aist.go.jp>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage
Date: Fri, 19 Jul 2013 04:56:43 -0600 [thread overview]
Message-ID: <51E91B6B.8040602@redhat.com> (raw)
In-Reply-To: <1374200625-7125-1-git-send-email-p.pawit@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On 07/18/2013 08:23 PM, Pawit Pornkitprasan wrote:
> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
>
> Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
> ---
> migration.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/migration.c b/migration.c
> index 9f5a423..4c16f2e 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>
> info->has_status = true;
> info->status = g_strdup("completed");
> + info->has_total_time = true;
> info->total_time = s->total_time;
> info->has_downtime = true;
> info->downtime = s->downtime;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-19 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 2:23 [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage Pawit Pornkitprasan
2013-07-19 10:56 ` Eric Blake [this message]
2013-07-22 7:29 ` Orit Wasserman
2013-07-29 19:02 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E91B6B.8040602@redhat.com \
--to=eblake@redhat.com \
--cc=p.pawit@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=takano-ryousei@aist.go.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).