From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V08Ml-00045b-Dh for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:56:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V08Mj-0008JP-Sd for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:56:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V08Mj-0008JI-Jd for qemu-devel@nongnu.org; Fri, 19 Jul 2013 06:56:49 -0400 Message-ID: <51E91B6B.8040602@redhat.com> Date: Fri, 19 Jul 2013 04:56:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374200625-7125-1-git-send-email-p.pawit@gmail.com> In-Reply-To: <1374200625-7125-1-git-send-email-p.pawit@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E9iFQBdIR3SPdj25gJ0mmbhuniXU3mEjF" Subject: Re: [Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pawit Pornkitprasan Cc: Ryousei Takano , qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E9iFQBdIR3SPdj25gJ0mmbhuniXU3mEjF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 08:23 PM, Pawit Pornkitprasan wrote: > The "completed" stage sets total_time but not has_total_time and > thus it is not sent via QMP reply (but sent via HMP nevertheless) >=20 > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/migration.c b/migration.c > index 9f5a423..4c16f2e 100644 > --- a/migration.c > +++ b/migration.c > @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) > =20 > info->has_status =3D true; > info->status =3D g_strdup("completed"); > + info->has_total_time =3D true; > info->total_time =3D s->total_time; > info->has_downtime =3D true; > info->downtime =3D s->downtime; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E9iFQBdIR3SPdj25gJ0mmbhuniXU3mEjF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6RtrAAoJEKeha0olJ0NqRXQH/2DLXLVEGFYhfq5jgBcgWAnE 5Ov8GtxOtsBlqaHaHZc1UHJC30SVs/gzsmfB5y6VxvCwYfIc4lMQvI2SFKbZmQuM xpDMnjAOBWoeXoxI9Pcna1YxxBxq9gY2SWw+40ySNBul9aNRkvc0iJcVUqYMiB6x MoKVNhrGIjJvIW+jlpx92wE7vpgQiL8qi0f7Kw1+KfCcb4nw4EJqxi9oW15/ky+b 3wEVIM2aQEdxFlEHYCAO4HjTZylhtUbTDgAfbv3HHgOtbmJUFAC4lNEZCK9PC3It kUWAHow256Bwqz5iKId+h5n4sfv/CaIk1/e97FpNZaAV9i/SPpSJsOlT8wU6c7s= =LUs1 -----END PGP SIGNATURE----- --E9iFQBdIR3SPdj25gJ0mmbhuniXU3mEjF--