From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: famz@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 03/17] cow: do not call bdrv_co_is_allocated
Date: Fri, 19 Jul 2013 06:42:19 -0600 [thread overview]
Message-ID: <51E9342B.2010809@redhat.com> (raw)
In-Reply-To: <1373992168-26043-4-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> As we change bdrv_is_allocated to gather more information from bs and
> bs->file, it will become a bit slower. It is still appropriate for online
> jobs, but not for reads/writes. Call the internal function instead.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/cow.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-19 12:42 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 16:29 [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 01/17] cow: make reads go at a decent speed Paolo Bonzini
2013-07-19 12:31 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 02/17] cow: make writes go at a less indecent speed Paolo Bonzini
2013-07-19 12:40 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 03/17] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-07-19 12:42 ` Eric Blake [this message]
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 04/17] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-07-19 12:44 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-07-19 12:46 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 06/17] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-07-19 12:57 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-07-19 13:05 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 08/17] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-07-19 13:21 ` Eric Blake
2013-07-19 13:23 ` Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 09/17] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-07-19 13:43 ` Eric Blake
2013-07-25 12:13 ` Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value Paolo Bonzini
2013-07-19 6:35 ` Peter Lieven
2013-07-19 9:14 ` Paolo Bonzini
2013-07-19 6:48 ` Peter Lieven
2013-07-19 9:12 ` Paolo Bonzini
2013-07-19 9:58 ` Paolo Bonzini
2013-07-19 10:04 ` Peter Lieven
2013-07-19 12:13 ` Paolo Bonzini
2013-07-19 13:06 ` Peter Lieven
2013-07-20 7:00 ` Paolo Bonzini
2013-07-23 21:18 ` Peter Lieven
2013-07-19 16:52 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 11/17] block: return get_block_status data and flags for formats Paolo Bonzini
2013-07-19 19:25 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand Paolo Bonzini
2013-07-18 7:25 ` Fam Zheng
2013-07-18 8:55 ` Paolo Bonzini
2013-07-19 19:36 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-07-17 17:50 ` Peter Lieven
2013-07-19 19:37 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 14/17] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-07-19 19:48 ` Eric Blake
2013-07-25 12:16 ` Paolo Bonzini
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents Paolo Bonzini
2013-07-19 20:10 ` Eric Blake
2013-08-02 15:05 ` Christoph Hellwig
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 16/17] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-07-19 20:11 ` Eric Blake
2013-07-16 16:29 ` [Qemu-devel] [PATCH v2 17/17] block: look for zero blocks in bs->file Paolo Bonzini
2013-07-19 7:33 ` Stefan Hajnoczi
2013-07-19 17:07 ` Paolo Bonzini
2013-07-23 21:18 ` Peter Lieven
2013-07-19 20:12 ` Eric Blake
2013-07-16 16:56 ` [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata Eric Blake
2013-07-16 16:57 ` Paolo Bonzini
2013-07-19 10:48 ` Wenchao Xia
2013-07-19 12:14 ` Paolo Bonzini
2013-07-20 0:19 ` Wenchao Xia
2013-07-18 8:17 ` Peter Lieven
2013-07-18 8:58 ` Paolo Bonzini
2013-07-19 4:45 ` Stefan Hajnoczi
2013-07-19 7:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E9342B.2010809@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).