From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0A0w-0007H1-0l for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:42:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0A0u-0003KU-RT for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:42:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0A0u-0003K4-Jg for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:42:24 -0400 Message-ID: <51E9342B.2010809@redhat.com> Date: Fri, 19 Jul 2013 06:42:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373992168-26043-1-git-send-email-pbonzini@redhat.com> <1373992168-26043-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1373992168-26043-4-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3aW0xkOvlwtvlDchVM0SCXR9ILm7WWWWu" Subject: Re: [Qemu-devel] [PATCH v2 03/17] cow: do not call bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3aW0xkOvlwtvlDchVM0SCXR9ILm7WWWWu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/16/2013 10:29 AM, Paolo Bonzini wrote: > As we change bdrv_is_allocated to gather more information from bs and > bs->file, it will become a bit slower. It is still appropriate for onl= ine > jobs, but not for reads/writes. Call the internal function instead. >=20 > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3aW0xkOvlwtvlDchVM0SCXR9ILm7WWWWu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6TQrAAoJEKeha0olJ0NqEz0H/RZBYc7gl6ltQ6kOmV5knVbq meMArzxalyEfJ3ckH2fAbW2/KTQNhKeI5WfuX4fpXeqmMvVBy5BWb5fuGbyzGwQg 4QhyvXVtUlMakpNDEtQRhXQzqM3+qJbQAUmBFHLGVwltEisc9NgYAyWetWxai3Jx 5SVGq/RGfWOiM/1kCflzfJa/Xxyhql1TzHzxgg9Uv7f6bpMiDGHkDUgiWu4Ev30R kPvCLruG/0eJONgVPlUcPvcZSwHbWUL+mhBmP01yjAsFzqkKH/XmUbHKk6D3LX6D 2bRH9ETOoLqAOGMLn28VLjc7rrf74rPknX08q16ifwKMHQelNjPUZnvVUDgTP7Y= =Cc7B -----END PGP SIGNATURE----- --3aW0xkOvlwtvlDchVM0SCXR9ILm7WWWWu--