From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V0AGV-00068x-V5
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:58:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V0AGU-0000PL-6e
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:58:31 -0400
Received: from mail-pd0-f175.google.com ([209.85.192.175]:41968)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V0AGU-0000On-0C
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 08:58:30 -0400
Received: by mail-pd0-f175.google.com with SMTP id 4so4200035pdd.20
	for <qemu-devel@nongnu.org>; Fri, 19 Jul 2013 05:58:29 -0700 (PDT)
Message-ID: <51E937EE.20604@ozlabs.ru>
Date: Fri, 19 Jul 2013 22:58:22 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <87vc5hro46.fsf@linux.vnet.ibm.com>
	<87sj0lrnih.fsf@linux.vnet.ibm.com> <51E93624.5040702@redhat.com>
In-Reply-To: <51E93624.5040702@redhat.com>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] commit 08521e2 breaks SLOF usb boot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>

On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
>> Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> writes:
>>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
>>> Author: Paolo Bonzini <pbonzini@redhat.com>
>>> Date:   Fri May 24 12:54:01 2013 +0200
>>>
>>>     memory: add big endian support to access_with_adjusted_size
>>>     
>>>     This will be used to split 8-byte access down to two four-byte accesses.
>>>     
>>>     Reviewed-by: Richard Henderson <rth@twiddle.net>
>>>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>>
>>> If I hack the above funniness in my USB EHCI driver, somewhere down the
>>> qemu crashes at code introduced by this patch:
>>>
>>> Program received signal SIGSEGV, Segmentation fault.
>>> 0x0000000000000000 in ?? ()
>>> (gdb) bt
>>> #0 0x0000000000000000 in ?? ()
>>> #1 0x00005555557a0ea4 in access_with_adjusted_size (addr=addr@entry=12, value=value@entry=0x7fffd5a86680, size=size@entry=1, access_size_min=<optimized out>, access_size_max=<optimized out>,
>>> access=0x5555557a1f80 <memory_region_oldmmio_write_accessor>, opaque=0x5555567f8ab8) at /home/nikunj/work/power/code/qemu/memory.c:396
>>> #2 0x00005555557a5ebb in memory_region_dispatch_write (size=1, data=0, addr=12, mr=0x5555567f8ab8) at /home/nikunj/work/power/code/qemu/memory.c:998
>>>
>>> Reverting this, I can safely boot using a usb-storage device put on ehci controller.
>>
>> Just reverting this patch does not help though, i will need to figure
>> which all commits are bad.
> 
> Hi Nikunj,
> 
> can you try the attached patch?
> 
> Alexey, with some luck it may even fix virtio-blk too.


Heh. Bad luck. The behaviour has changed slightly but it still does not work.




-- 
Alexey