From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0ANg-0001CX-OF for qemu-devel@nongnu.org; Fri, 19 Jul 2013 09:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0ANb-00036r-Nz for qemu-devel@nongnu.org; Fri, 19 Jul 2013 09:05:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0ANb-00036m-7L for qemu-devel@nongnu.org; Fri, 19 Jul 2013 09:05:51 -0400 Message-ID: <51E939A9.9090802@redhat.com> Date: Fri, 19 Jul 2013 07:05:45 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373992168-26043-1-git-send-email-pbonzini@redhat.com> <1373992168-26043-8-git-send-email-pbonzini@redhat.com> In-Reply-To: <1373992168-26043-8-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cb1VWc38wJvAUXx8QAgVErjDvgkSEXU73" Subject: Re: [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cb1VWc38wJvAUXx8QAgVErjDvgkSEXU73 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/16/2013 10:29 AM, Paolo Bonzini wrote: > qemu-img convert is assuming "that sectors which are unallocated in the= input > image are present in both the output's and input's base images", but it= is > only doing this if the output image is zero initialized. And checking = if > the output image is zero initialized does not make much sense if the > output image is copy-on-write. Always do the test. >=20 > Signed-off-by: Paolo Bonzini > --- > qemu-img.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cb1VWc38wJvAUXx8QAgVErjDvgkSEXU73 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6TmpAAoJEKeha0olJ0NqBO4H/R/oRPFAgPbRRtZ3qd/9OyHX b8bb5MsoGMKRbw0OqH9k5SXV0hhk6QGkbYoc4P4FhO9UpGErCLlZZZF8HsILLRkk c29WeVdiZ6S9N5t10IyoBByhKV4JdWjQxGFKORtSHpwb6BImOY0NfdruEhzVvqLf Aw7KssoS3tXDLy4DWYdNe8miQsZZbNUhVrLQigSOf6NhuLTf+cagQePmuIO4cZqw hZJuqli72kk0cLyiRss5XOoWkhCMIN7hVf6HzwnuQC3RU4ou0zoPWoAkTa2h6XKA Op0KBFcPQXkKukT11oV+pcwbe0D7EmBdeUekKJteHIcu8SCWA31/qfCaTYqAios= =RnEC -----END PGP SIGNATURE----- --cb1VWc38wJvAUXx8QAgVErjDvgkSEXU73--