From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54234)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Kwok_Yeung@mentor.com>) id 1V0CIx-0007cW-GX
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 11:09:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Kwok_Yeung@mentor.com>) id 1V0CIt-0004Sy-3o
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 11:09:11 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:39464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Kwok_Yeung@mentor.com>) id 1V0CIs-0004SR-VG
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 11:09:07 -0400
Message-ID: <51E9569C.5050400@codesourcery.com>
Date: Fri, 19 Jul 2013 16:09:16 +0100
From: Kwok Cheung Yeung <kcy@codesourcery.com>
MIME-Version: 1.0
References: <1374245233-14732-1-git-send-email-kcy@codesourcery.com>
	<CAFEAcA_jASZBOYknbbT6O3wGhM=pPk-o7iUEdRnKcCg7vztE_g@mail.gmail.com>
In-Reply-To: <CAFEAcA_jASZBOYknbbT6O3wGhM=pPk-o7iUEdRnKcCg7vztE_g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding
 when processing trap exceptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org, aurelien@aurel32.net

On 19/07/2013 3:52 PM, Peter Maydell wrote:
> On 19 July 2013 15:47, Kwok Cheung Yeung <kcy@codesourcery.com> wrote:
>> Decode trap instructions during the handling of an EXCP_TRAP according to
>> the current ISA mode.
>>
>> Signed-off-by: Kwok Cheung Yeung <kcy@codesourcery.com>
>> ---
>>   linux-user/main.c | 20 ++++++++++++++++++--
>>   1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> v2: Read microMIPS instructions sequentially as 16-bit values to avoid
>>      endianess issues. Add braces to if statement to conform to formatting
>>      standards.
>
> This code looks OK but last time round I asked about
> EXCP_BREAK -- why doesn't that also need to change?
>

This patch was intended to fix the handling of floating-point exceptions while 
running the GCC unit tests (gcc.c-torture/execute/20101011-1.c) on microMIPS, 
which only requires EXCP_TRAP to work properly. I'll post a version with 
EXCP_BREAK fixed shortly.

Thanks

Kwok