From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0GU6-0002Wl-OF for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:36:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0GU4-0007Kb-RX for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:36:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0GU4-0007KQ-Im for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:36:56 -0400 Message-ID: <51E99552.7020705@redhat.com> Date: Fri, 19 Jul 2013 13:36:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1373992168-26043-1-git-send-email-pbonzini@redhat.com> <1373992168-26043-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1373992168-26043-13-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SGsFPuxMPN3BaR4PqAMXKqWtn3KAM73nq" Subject: Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: famz@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SGsFPuxMPN3BaR4PqAMXKqWtn3KAM73nq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/16/2013 10:29 AM, Paolo Bonzini wrote: > This command dumps the metadata of an entire chain, in either tabular o= r JSON > format. >=20 > Signed-off-by: Paolo Bonzini > --- > v1->v2: mention encrypted clusters, use PRId64 >=20 > qemu-img-cmds.hx | 6 ++ > qemu-img.c | 185 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 191 insertions(+) Missing a change to qemu-img.texi to list the documentation required ther= e. It might also help to show a sample of the output in the commit message. I didn't spot anything else beyond your other reviewers. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SGsFPuxMPN3BaR4PqAMXKqWtn3KAM73nq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6ZVSAAoJEKeha0olJ0NqO0kIAKMLYAmMv2VBIV8k5mL2fM1T ObHUGfOKBuYbjdZLBPWpCKI7TMIn5bizSMv/OK2iRicJ3mD9ZGxiZk09HEangC2w gpBRYrs+x+l1FSRCC04Glbf9/pnpONj025cOFlMO2OOG+/JANRBs/lKB65iLGXwR V7iu946h2j/UdDA3N8SB6tlo4dfLHMzRIIONJH/BFhny5WW9HWQ/HWgUHSl5B17I jMGuVE+jOwodNzZfYCaNm/EhcYVVqhVBHLkTpWJM5jx52hKo1NwuIwrZZ2qr5cAy RSuCqFlANsHHC4D63OiU8dNfsNuygxu5VM4DqD4SG1J+ViDXiAXrEnGLY5atjuU= =NX89 -----END PGP SIGNATURE----- --SGsFPuxMPN3BaR4PqAMXKqWtn3KAM73nq--