From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0GYE-0005G5-WC for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0GYD-0001Iq-5F for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:41:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0GYC-0001Ii-Qa for qemu-devel@nongnu.org; Fri, 19 Jul 2013 15:41:13 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6JJfCB6011432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Jul 2013 15:41:12 -0400 Message-ID: <51E99656.7020209@redhat.com> Date: Fri, 19 Jul 2013 13:41:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374253411-17162-1-git-send-email-imain@redhat.com> <1374253411-17162-2-git-send-email-imain@redhat.com> In-Reply-To: <1374253411-17162-2-git-send-email-imain@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HrCRivTsCvkJI2JDtHoBGUBwMxTfuFm8f" Subject: Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HrCRivTsCvkJI2JDtHoBGUBwMxTfuFm8f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/19/2013 11:03 AM, Ian Main wrote: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NONE and TOP modes of synchronization. >=20 > Signed-off-by: Ian Main > --- > block/backup.c | 91 +++++++++++++++++++++++++++++++--------= -------- > blockdev.c | 25 ++++++++----- > include/block/block_int.h | 4 ++- > qapi-schema.json | 4 +++ > qmp-commands.hx | 1 + > 5 files changed, 86 insertions(+), 39 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -1807,6 +1807,10 @@ > # @format: #optional the format of the new destination, default is to > # probe if @mode is 'existing', else the format of the source= > # > +# @sync: what parts of the disk image should be copied to the destinat= ion > +# (all the disk, only the sectors allocated in the topmost imag= e, or > +# only new I/O). > +# > # @mode: #optional whether and how QEMU should create a new image, def= ault is > # 'absolute-paths'. > # This hunk is still wrong. And we still haven't answered the meta-question on whether @format should be mandatory (which I'd rather fix that first, then rebase this on top of that). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HrCRivTsCvkJI2JDtHoBGUBwMxTfuFm8f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6ZZWAAoJEKeha0olJ0NqvRkH/RjwD2uKEqNQQ4sKkpWAuD0r tXxkxkHcp0rLGyFkqUqOZJ+t3sWjvhQnRpHHpsCe6z+/fjX1XRHkyUo6FyrTCWpe 9veO849jESZbPWsZsTa5nZwm+TUZwR+I8EaORY2R+tXOozxwbn+Q6DSwohNWnERP Z0c+8OFyedRVpwdey6b5CeBMFJ45cFJ8h1qgJQGF5BGPO6S+v28bYh4apmScXS2P Cli+GiNfoUb4NKkpufjRr5ednGmgpYyV++7HVkc6JYCiH1wMlemUZpMmisuC3kGm gF+B9yvZGk6pixbahmK+9KHd0wEyKBwjCX2POdj6qbRWGSga+rJxiA+jgWyFv5E= =OIdc -----END PGP SIGNATURE----- --HrCRivTsCvkJI2JDtHoBGUBwMxTfuFm8f--