From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Gzb-00053R-Fk for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:09:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0Gza-0008AJ-IQ for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:09:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Gza-00089t-AD for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:09:30 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6JK9TpE012649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Jul 2013 16:09:29 -0400 Message-ID: <51E99CEC.3010404@redhat.com> Date: Fri, 19 Jul 2013 22:09:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130719184124.15864.20803.stgit@bling.home> In-Reply-To: <20130719184124.15864.20803.stgit@bling.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Fix zero-sized memory region print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org Il 19/07/2013 20:42, Alex Williamson ha scritto: > if mr->size == 0, then > > int128_get64(int128_sub(mr->size, int128_make64(1))) => assert(!a.hi) > > Also, use int128_one(). > > Signed-off-by: Alex Williamson Reviewed-by: Paolo Bonzini > --- > memory.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/memory.c b/memory.c > index c8f9a2b..6e17c21 100644 > --- a/memory.c > +++ b/memory.c > @@ -1788,7 +1788,9 @@ static void mtree_print_mr(fprintf_function mon_printf, void *f, > "-" TARGET_FMT_plx "\n", > base + mr->addr, > base + mr->addr > - + (hwaddr)int128_get64(int128_sub(mr->size, int128_make64(1))), > + + (int128_nz(mr->size) ? > + (hwaddr)int128_get64(int128_sub(mr->size, > + int128_one())) : 0), > mr->priority, > mr->romd_mode ? 'R' : '-', > !mr->readonly && !(mr->rom_device && mr->romd_mode) ? 'W' > @@ -1803,7 +1805,9 @@ static void mtree_print_mr(fprintf_function mon_printf, void *f, > TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %c%c): %s\n", > base + mr->addr, > base + mr->addr > - + (hwaddr)int128_get64(int128_sub(mr->size, int128_make64(1))), > + + (int128_nz(mr->size) ? > + (hwaddr)int128_get64(int128_sub(mr->size, > + int128_one())) : 0), > mr->priority, > mr->romd_mode ? 'R' : '-', > !mr->readonly && !(mr->rom_device && mr->romd_mode) ? 'W' >