From: Paolo Bonzini <pbonzini@redhat.com>
To: famz@redhat.com
Cc: Ian Main <imain@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.
Date: Fri, 19 Jul 2013 22:15:24 +0200 [thread overview]
Message-ID: <51E99E5C.2050205@redhat.com> (raw)
In-Reply-To: <20130719011339.GA1244@T430s.nay.redhat.com>
Il 19/07/2013 03:13, Fam Zheng ha scritto:
>>> > > Also set target->backing_file and target->backing_format here? Paolo?
>> >
>> > I don't think so, it is temporary while the job runs so that the NBD
>> > server can already return the actual data.
> OK.
>
> For NBD export, it's also going to have a name, to be used with
> nbd_server_add. So should we call bdrv_set_in_use() here to protect
> target from being used elsewhere?
I think it'd still be safe, but it's probably a good idea anyway.
Paolo
next prev parent reply other threads:[~2013-07-19 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 20:04 [Qemu-devel] [PATCH V4 0/4] Implement sync modes for drive-backup Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 1/4] " Ian Main
2013-07-18 17:19 ` Eric Blake
2013-07-18 19:06 ` Ian Main
2013-07-18 19:54 ` Eric Blake
2013-07-19 21:56 ` Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 2/4] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup Ian Main
2013-07-18 6:39 ` Fam Zheng
2013-07-18 13:13 ` Paolo Bonzini
2013-07-19 1:13 ` Fam Zheng
2013-07-19 20:15 ` Paolo Bonzini [this message]
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none Ian Main
2013-07-18 17:27 ` Eric Blake
2013-07-18 17:32 ` Eric Blake
2013-07-18 18:03 ` Ian Main
2013-07-18 18:48 ` Eric Blake
2013-07-18 18:06 ` Ian Main
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E99E5C.2050205@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).