From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V0H5Y-0002nm-Fb
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:15:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V0H5W-0003SZ-Ng
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:15:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1V0H5W-0003S5-Cx
	for qemu-devel@nongnu.org; Fri, 19 Jul 2013 16:15:38 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6JKFa9H015063
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 19 Jul 2013 16:15:37 -0400
Message-ID: <51E99E5C.2050205@redhat.com>
Date: Fri, 19 Jul 2013 22:15:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1374091462-18391-1-git-send-email-imain@redhat.com>
	<1374091462-18391-4-git-send-email-imain@redhat.com>
	<20130718063928.GH29052@T430s.nay.redhat.com>
	<51E7E9FB.5040202@redhat.com>
	<20130719011339.GA1244@T430s.nay.redhat.com>
In-Reply-To: <20130719011339.GA1244@T430s.nay.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing
 backup.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: famz@redhat.com
Cc: Ian Main <imain@redhat.com>, qemu-devel@nongnu.org

Il 19/07/2013 03:13, Fam Zheng ha scritto:
>>> > > Also set target->backing_file and target->backing_format here? Paolo?
>> > 
>> > I don't think so, it is temporary while the job runs so that the NBD
>> > server can already return the actual data.
> OK.
> 
> For NBD export, it's also going to have a name, to be used with
> nbd_server_add. So should we call bdrv_set_in_use() here to protect
> target from being used elsewhere?

I think it'd still be safe, but it's probably a good idea anyway.

Paolo